You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/10/16 06:09:03 UTC

[jira] [Created] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources.

Lars Hofhansl created HBASE-6996:
------------------------------------

             Summary: HRegion.mutateRowsWithLocks should call checkResources.
                 Key: HBASE-6996
                 URL: https://issues.apache.org/jira/browse/HBASE-6996
             Project: HBase
          Issue Type: Sub-task
            Reporter: Lars Hofhansl
             Fix For: 0.94.3, 0.96.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476774#comment-13476774 ] 

Hudson commented on HBASE-6996:
-------------------------------

Integrated in HBase-0.94 #538 (See [https://builds.apache.org/job/HBase-0.94/538/])
    HBASE-6996 HRegion.mutateRowsWithLocks should call checkResources/checkReadOnl (Revision 1398645)

     Result = SUCCESS
larsh : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

                
> HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly
> --------------------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources.

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6996:
---------------------------------

    Fix Version/s:     (was: 0.96.0)

Trunk is already doing this correctly, so this is only for 0.94.
                
> HRegion.mutateRowsWithLocks should call checkResources.
> -------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490387#comment-13490387 ] 

Hudson commented on HBASE-6996:
-------------------------------

Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
    HBASE-6996 HRegion.mutateRowsWithLocks should call checkResources/checkReadOnl (Revision 1398645)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

                
> HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly
> --------------------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476751#comment-13476751 ] 

ramkrishna.s.vasudevan commented on HBASE-6996:
-----------------------------------------------

+1 Lars. Thanks.

                
> HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly
> --------------------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6996:
---------------------------------

    Summary: HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly  (was: HRegion.mutateRowsWithLocks should call checkResources.)
    
> HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly
> --------------------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources.

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6996:
---------------------------------

    Attachment: 6996-0.94.txt

Simple 0.94 patch.

Ran the tests that exercise mutateRowsWithLocks:
* TestFromClientSide.testMultiRowMutation
* TestAtomicOperation

Committing soon unless there are objections.
                
> HRegion.mutateRowsWithLocks should call checkResources.
> -------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources.

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6996:
---------------------------------

    Description: Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.
    
> HRegion.mutateRowsWithLocks should call checkResources.
> -------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>             Fix For: 0.94.3, 0.96.0
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl resolved HBASE-6996.
----------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed

Committed 0.94.
                
> HRegion.mutateRowsWithLocks should call checkResources/checkReadOnly
> --------------------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3
>
>         Attachments: 6996-0.94.txt
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-6996) HRegion.mutateRowsWithLocks should call checkResources.

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl reassigned HBASE-6996:
------------------------------------

    Assignee: Lars Hofhansl
    
> HRegion.mutateRowsWithLocks should call checkResources.
> -------------------------------------------------------
>
>                 Key: HBASE-6996
>                 URL: https://issues.apache.org/jira/browse/HBASE-6996
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3, 0.96.0
>
>
> Turns out that mutateRowsWithLocks does not call check resources, so these will not get blocked when the memstore gets to large.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira