You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org> on 2009/04/04 15:33:12 UTC

[jira] Created: (OFBIZ-2271) New targets for custom component's build.xml file

New targets for custom component's build.xml file
-------------------------------------------------

                 Key: OFBIZ-2271
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
             Project: OFBiz
          Issue Type: New Feature
          Components: framework
            Reporter: Ashish Vijaywargiya
            Priority: Trivial


There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.

The workflow could be the following one:
1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
that will create a patch and store it in the patches folder.
3) Every time the component is built, we could revert the mods and reapply all the patches.

--
Ashish Vijaywargiya


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by seemaaparna tiwari <se...@gmail.com>.
I have improved the following patch

Regards

Seema Tiwari
Ritika Somani


On Tue, Apr 7, 2009 at 4:23 PM, Hans Bakker (JIRA) <ji...@apache.org> wrote:

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696473#action_12696473]
>
> Hans Bakker commented on OFBIZ-2271:
> ------------------------------------
>
> This sounds pretty good, however could you explain its usage in the target
> description field so it will show in the 'ant -projecthelp' list?
>
> thanks in advance,
>
> Hans
>
> > New targets for custom component's build.xml file
> > -------------------------------------------------
> >
> >                 Key: OFBIZ-2271
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
> >             Project: OFBiz
> >          Issue Type: New Feature
> >          Components: framework
> >            Reporter: Ashish Vijaywargiya
> >            Assignee: Jacopo Cappellato
> >            Priority: Trivial
> >         Attachments: New_Ant_Targets.patch
> >
> >
> > There is now an ant target to automatically generate the layout of an
> hot-deploy component.(i.e ant create-component)
> > It would be nice to add, to the generated build.xml file in the
> hot-deploy component, ant targets to create/apply/revert patches for the
> framework, applications and specialpurpose.
> > The idea is to automate the process of creating patches (and storing them
> in the patches folder of the custom component), applying them and reverting.
> > The workflow could be the following one:
> > 1) A developer creates a custom hot deploy component for a customer using
> the proper ant target.
> > 2) The developer modifies the code (e.g. config files etc...) in
> framework, applications and specialpurpose, then run the "create-patch"
> target
> > that will create a patch and store it in the patches folder.
> > 3) Every time the component is built, we could revert the mods and
> reapply all the patches.
> > --
> > Ashish Vijaywargiya
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Commented: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716009#action_12716009 ] 

Anil K Patel commented on OFBIZ-2271:
-------------------------------------

Ashish,
Can you please summarize this feature and also also create little user guide for it on Ofbiz confluence? It will be nice to have a document handy as compared to digging in Jira.

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696473#action_12696473 ] 

Hans Bakker commented on OFBIZ-2271:
------------------------------------

This sounds pretty good, however could you explain its usage in the target description field so it will show in the 'ant -projecthelp' list?

thanks in advance,

Hans

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-2271:
---------------------------------------

    Attachment: New_Ant_Targets.patch

Few comments :

1) We should avoid the unnecessary lines in the patch. (See unnecessary + & - in the patch)
-
+        
     <!-- ================================================================== -->
     <!-- Initialization of all property settings                            -->
     <!-- ================================================================== -->
-
+    
     <property environment="env"/>
     <property name="desc" value="@component-resource-name@ Component"/>
     <property name="name" value="ofbiz-@component-name@"/>
@@ -15,7 +15,7 @@
     <property name="dtd.dir" value="dtd"/>
     <property name="lib.dir" value="lib"/>
     <property name="build.dir" value="build"/>
-
+        
     <path id="local.class.path">
         <fileset dir="${lib.dir}" includes="*.jar"/>
         <fileset dir="../../framework/base/lib" includes="*.jar"/>
@@ -31,19 +31,19 @@
         <fileset dir="../../framework/webapp/lib" includes="*.jar"/>
         <fileset dir="../../framework/webapp/build/lib" includes="*.jar"/>
     </path>
-
+        
     <!-- ================================================================== -->
     <!-- Compilation of the source files                                                                                                                         -->
     <!-- ================================================================== -->
-
+    
     <target name="classes" depends="prepare">
         <javac15/>
     </target>
-
+    
     <!-- ================================================================== -->
     <!-- Build JavaDoc                                                      -->
     <!-- ================================================================== -->
-
+    

2) Providing the option to use "component-name" property that has been setup in the top of build.xml file instead of passing it from command line.
(using -Dcomponent-name="name of component")

-    <property name="name" value="ofbiz-@component-name@"/>
+    <property name="component-name" value="ofbiz-@component-name@"/>


3) We should avoid following details from the patch.
### Eclipse Workspace Patch 1.0
#P ofbiztest

Either create patch from the terminal or Select second option "Project" instead of "Workspace".
You can see the "Workspace" option selected by default when you will click on the "Next" button while creating patch from eclipse.

--
Ashish Vijaywargiya

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-2271.
------------------------------------

    Resolution: Fixed

Thanks to Seema Tiwari & Ritika Somani (and Ashish for the review), your patch is in rev. 762757.



> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-2271:
----------------------------------------

    Assignee: Jacopo Cappellato

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Seema-Tiwari (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seema-Tiwari updated OFBIZ-2271:
--------------------------------

    Attachment: New_Ant_Targets.patch

Add ant targets to the build script of the automatically generated hot-deploy components for managing patches

Now description of these targets can be viewed through 'ant -projecthelp option

Thanks and Regards 

Seema Tiwari

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716265#action_12716265 ] 

Ashish Vijaywargiya commented on OFBIZ-2271:
--------------------------------------------

First I will see the existing document, but if didn't find any then I will create it.

--
Ashish

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Seema-Tiwari (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696469#action_12696469 ] 

Seema-Tiwari edited comment on OFBIZ-2271 at 4/7/09 3:45 AM:
-------------------------------------------------------------

New ant targets to the build script of the automatically generated hot-deploy components for managing patches


Thanks and Regards

Seema Tiwari
Ritika Somani




      was (Author: seematiwari):
    New ant targets to the build script of the automatically generated hot-deploy components for managing patches




  
> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Seema-Tiwari (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seema-Tiwari updated OFBIZ-2271:
--------------------------------

    Attachment: New_Ant_Targets.patch

New ant targets to the build script of the automatically generated hot-deploy components for managing patches





> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2271) New targets for custom component's build.xml file

Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696533#action_12696533 ] 

Ashish Vijaywargiya commented on OFBIZ-2271:
--------------------------------------------

Thanks Jacopo for taking care of this patch.

--
Ashish Vijaywargiya

> New targets for custom component's build.xml file
> -------------------------------------------------
>
>                 Key: OFBIZ-2271
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2271
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Ashish Vijaywargiya
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: New_Ant_Targets.patch, New_Ant_Targets.patch, New_Ant_Targets.patch
>
>
> There is now an ant target to automatically generate the layout of an hot-deploy component.(i.e ant create-component)
> It would be nice to add, to the generated build.xml file in the hot-deploy component, ant targets to create/apply/revert patches for the framework, applications and specialpurpose.
> The idea is to automate the process of creating patches (and storing them in the patches folder of the custom component), applying them and reverting.
> The workflow could be the following one:
> 1) A developer creates a custom hot deploy component for a customer using the proper ant target. 
> 2) The developer modifies the code (e.g. config files etc...) in framework, applications and specialpurpose, then run the "create-patch" target 
> that will create a patch and store it in the patches folder.
> 3) Every time the component is built, we could revert the mods and reapply all the patches.
> --
> Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.