You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "cvictory (GitHub)" <gi...@apache.org> on 2019/02/28 08:34:38 UTC

[GitHub] [incubator-dubbo] cvictory opened pull request #3578: fix issue #3289. enhance tagRoute: support ip expression match

https://github.com/apache/incubator-dubbo/issues/3289

It support both ipv4 and ipv6.  The supported format of ip expression as follow:
1. subnet . such as 192.168.1.192/26,  234e:0:4567::3d/64 
2.all ip named '*.*.*.* '
3. 192.168.1.*  and  234e:0:4567:0:0:0:3d:*
4. 192.168.1.1-23 and 234e:0:4567:0:0:0:3d:0-ea

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
Keeps outputting the following log:

[07/03/19 04:45:12:012 CST] main  INFO utils.NetUtils:  [DUBBO] The pattern port is not equals to port form param., dubbo version: 2.7.1-SNAPSHOT, current host:



[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=h1) Report
> Merging [#3578](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e1cb03bac5d295c3e1140a02fccd5a8c7384cec9?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `77.53%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
+ Coverage     64.21%   64.23%   +0.01%     
  Complexity       71       71              
============================================
  Files           664      666       +2     
  Lines         28635    28975     +340     
  Branches       4768     4812      +44     
============================================
+ Hits          18389    18612     +223     
- Misses         8029     8109      +80     
- Partials       2217     2254      +37
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `35.16% <0%> (-4.35%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `70.12% <84%> (+6.26%)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/CIDRUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ0lEUlV0aWxzLmphdmE=) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-6.53%)` | `0% <0%> (ø)` | |
| [...bo/metadata/integration/MetadataReportService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2ludGVncmF0aW9uL01ldGFkYXRhUmVwb3J0U2VydmljZS5qYXZh) | `78.04% <0%> (-6.17%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `72.97% <0%> (-2.71%)` | `0% <0%> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=footer). Last update [e1cb03b...19425cd](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=h1) Report
> Merging [#3578](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e1cb03bac5d295c3e1140a02fccd5a8c7384cec9?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `77.69%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
+ Coverage     64.21%   64.22%   +<.01%     
  Complexity       71       71              
============================================
  Files           664      665       +1     
  Lines         28635    28790     +155     
  Branches       4768     4795      +27     
============================================
+ Hits          18389    18490     +101     
- Misses         8029     8065      +36     
- Partials       2217     2235      +18
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `35.16% <0%> (-4.35%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `70.24% <84.21%> (+6.39%)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/CIDRUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ0lEUlV0aWxzLmphdmE=) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.11% <0%> (-8.24%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-6.53%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.94% <0%> (-4.73%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `46.87% <0%> (-1.05%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-0.95%)` | `0% <0%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=footer). Last update [e1cb03b...795e606](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=h1) Report
> Merging [#3578](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e1cb03bac5d295c3e1140a02fccd5a8c7384cec9?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `74.75%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
+ Coverage     64.15%   64.23%   +0.08%     
  Complexity       71       71              
============================================
  Files           664      665       +1     
  Lines         28635    28736     +101     
  Branches       4768     4785      +17     
============================================
+ Hits          18371    18459      +88     
  Misses         8045     8045              
- Partials       2219     2232      +13
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `35.16% <0%> (-4.35%)` | `0 <0> (ø)` | |
| [.../java/org/apache/dubbo/common/utils/CIDRUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ0lEUlV0aWxzLmphdmE=) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `67.8% <84.61%> (+3.94%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `46.87% <0%> (-1.05%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-0.95%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `72.97% <0%> (-0.68%)` | `0% <0%> (ø)` | |
| [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `81.11% <0%> (+0.92%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `67.39% <0%> (+2.17%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=footer). Last update [e1cb03b...c2e3612](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on pull request #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
The address here is expected to have port included: `127.0.0.1:20880`, but `NetUtils.matchIpExpression` can only handle raw IP.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=h1) Report
> Merging [#3578](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e1cb03bac5d295c3e1140a02fccd5a8c7384cec9?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `77.14%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
+ Coverage     64.21%   64.23%   +0.01%     
  Complexity       71       71              
============================================
  Files           664      666       +2     
  Lines         28635    28975     +340     
  Branches       4768     4812      +44     
============================================
+ Hits          18389    18612     +223     
- Misses         8029     8111      +82     
- Partials       2217     2252      +35
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ster/router/condition/config/ListenableRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVJvdXRlci5qYXZh) | `33.33% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `35.16% <8.33%> (-4.35%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `70.12% <84%> (+6.26%)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/CIDRUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ0lEUlV0aWxzLmphdmE=) | `84.61% <84.61%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.11% <0%> (-8.24%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-6.53%)` | `0% <0%> (ø)` | |
| [...bo/metadata/integration/MetadataReportService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2ludGVncmF0aW9uL01ldGFkYXRhUmVwb3J0U2VydmljZS5qYXZh) | `78.04% <0%> (-6.17%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.94% <0%> (-4.73%)` | `0% <0%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3578/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=footer). Last update [e1cb03b...244af12](https://codecov.io/gh/apache/incubator-dubbo/pull/3578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj closed pull request #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3578: fix issue #3289. enhance tagRoute: support ip expression match

Posted by "cvictory (GitHub)" <gi...@apache.org>.
I have fixed this one to support port configuration.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3578 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org