You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/02 11:22:57 UTC
[GitHub] [tvm] cbalint13 opened a new pull request, #13680: [TOPI] Expose mem_scope from generic conv2d variants to be more reusable
cbalint13 opened a new pull request, #13680:
URL: https://github.com/apache/tvm/pull/13680
This small PR enhances generic conv2d TOPI schedules to be even more reusable.
#### Changes:
1. Continues [PR #6714](https://github.com/apache/tvm/pull/6714) and expose memory scope via ```mem_scope```
2. Enhanches [schedule_conv_NCHWc_cpu_common_int8](https://github.com/apache/tvm/blob/f3d3ecebe189af77ba3ac5163882591aaf67d8b3/python/tvm/topi/generic/conv2d.py#L124) and [schedule_conv_NCHWc_cpu_1x1_int8](https://github.com/apache/tvm/blob/f3d3ecebe189af77ba3ac5163882591aaf67d8b3/python/tvm/topi/generic/conv2d.py#L271)
Does **not change current behaviour**, memory scope remains "global" by default.
#### Goal:
Flexibility and reusability of key generic schedules is desirable for custom ISA & custom ASIC designs.
There are use-cases where cache memory is not directly visible ("local") but generic TOPI is still very useful.
---
Cc @masahi , @vinx13 , @ZihengJiang please help with the review.
Thank you,
~Cristian.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13680: [TOPI] Expose mem_scope from generic conv2d variants to be more reusable
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13680:
URL: https://github.com/apache/tvm/pull/13680#issuecomment-1368861699
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `topi` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13680: [TOPI] Expose mem_scope from generic conv2d variants to be more reusable
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13680:
URL: https://github.com/apache/tvm/pull/13680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org