[GitHub] spark pull request #18484: [SPARK-21264][PYTHON] Call cross join path in joi...

[ueshin <gi...@git.apache.org>]

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18484#discussion_r125212648
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -2021,6 +2021,11 @@ def test_toDF_with_schema_string(self):
             self.assertEqual(df.schema.simpleString(), "struct<value:int>")
             self.assertEqual(df.collect(), [Row(key=i) for i in range(100)])
     
    +    def test_join_without_on(self):
    +        self.assertRaises(
    +            AnalysisException,
    +            lambda: self.spark.range(1).join(self.spark.range(1), how="inner").collect())
    --- End diff --
    
    Can you add a test for `spark.sql.crossJoin.enabled` is `true` case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org