[GitHub] kpm1985 commented on issue #952: [WIP] Issue 946

[GitBox <gi...@apache.org>]

kpm1985 commented on issue #952: [WIP] Issue 946
URL: https://github.com/apache/fluo/pull/952#issuecomment-339202011
 
 
   I haven't looked into this but is there any conversion methods that would
   work before adding another method, when you add a new method, this is a
   good justification.
   
    Also, in like thought, one could bridge the gap by introducing a new
   method to convert to byte [] and feed to existing API.
   
   This is your issue and you are doing great, just wanted to give you some
   options. Keep it up!
   
   On Oct 24, 2017 8:13 PM, "Joseph Koshakow" <no...@github.com> wrote:
   
   > *@jkosh44* commented on this pull request.
   > ------------------------------
   >
   > In modules/accumulo/src/main/java/org/apache/fluo/accumulo/iterators/
   > GarbageCollectionIterator.java
   > <https://github.com/apache/fluo/pull/952#discussion_r146745850>:
   >
   > > @@ -224,7 +226,7 @@ private void readColMetadata() throws IOException {
   >          }
   >
   >          if (keep) {
   > -          keys.add(new KeyValue(source.getTopKey(), val));
   > +          keys.add(source.getTopKey(), new Value(val));
   >
   > val here is of type byte[] I believe, currently there is no add(Key,
   > byte[]) method, but I can add it.
   >
   > ?
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/952#discussion_r146745850>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/Acg-LBuGt_gDw3QZjFritGDAq3_PPRd1ks5svqdkgaJpZM4QCDay>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services