[GitHub] [pulsar] congbobo184 removed a comment on issue #4692: [pulsar-sql]Pulsar SQL supports pulsar's primitive schemas and schema verison

[GitBox <gi...@apache.org>]

congbobo184 removed a comment on issue #4692: [pulsar-sql]Pulsar SQL supports pulsar's primitive schemas and schema verison
URL: https://github.com/apache/pulsar/pull/4692#issuecomment-510359968
 
 
   > @congbobo184 thanks for taking up the task for adding the functionality of allowing primitive types to be able to be queried by Pulsar SQL.
   > 
   > I have some concerns/questions:
   > 
   > 1. There are two major items that are covered in this PR: 1) Allowing primitive types to be queryable 2).  Add schema versioning.  Is it possible to have separate these two into independent PRs?  There are a lot of changes in this PR that that can potentially impact performance.  I would recommend having a PR that first enables querying of primitive types and then afterwards have a PR on schema versioning since it seems like adding schema versioning is changing much of how json and avro is deserialized for Pulsar SQL
   > 2. For the JSON schema handler you have the core json deserialization library from DslJson to Jackson.  We have benchmarked this before and DslJson is much faster at deserializing JSON than Jackson.  We can do one of two things: 1) keep using DslJson in Pulsar SQL or replace JsonSchema in Pulsar client to use DslJson as well.
   
   
   
   > @congbobo184 thanks for taking up the task for adding the functionality of allowing primitive types to be able to be queried by Pulsar SQL.
   > 
   > I have some concerns/questions:
   > 
   > 1. There are two major items that are covered in this PR: 1) Allowing primitive types to be queryable 2).  Add schema versioning.  Is it possible to have separate these two into independent PRs?  There are a lot of changes in this PR that that can potentially impact performance.  I would recommend having a PR that first enables querying of primitive types and then afterwards have a PR on schema versioning since it seems like adding schema versioning is changing much of how json and avro is deserialized for Pulsar SQL
   > 2. For the JSON schema handler you have the core json deserialization library from DslJson to Jackson.  We have benchmarked this before and DslJson is much faster at deserializing JSON than Jackson.  We can do one of two things: 1) keep using DslJson in Pulsar SQL or replace JsonSchema in Pulsar client to use DslJson as well.
   
   I agree with your suggestion. I will split it into two PR and use DslJson.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services