You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by davidlgr <gi...@git.apache.org> on 2014/04/23 07:53:31 UTC
[GitHub] incubator-storm pull request: trident DRPC bug fix.
GitHub user davidlgr opened a pull request:
https://github.com/apache/incubator-storm/pull/82
trident DRPC bug fix.
ack/fail will not remove FinishCondition due to unknown batchId for each
DRPC invocation. It makes the HashMap "_finishConditions" size
increasing. This patch fix the bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidlgr/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit bf73a0064c4581f615d46e1246e2178d4819afb8
Author: davidlgr <da...@163.com>
Date: 2014-04-23T05:47:51Z
trident DRPC bug fix.
ack/fail will not remove FinishCondition due to unknown batchId for each
DRPC invocation. It makes the HashMap "_finishConditions" size
increasing. This patch fix the bug.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-289: trident DRPC bug fix
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/82#issuecomment-41171821
looks good to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: trident DRPC bug fix.
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/82#issuecomment-41162753
Hi @davidlgr, would you add "STORM-289" to the title of this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-289: trident DRPC bug fix
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/82#issuecomment-41193975
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-289: trident DRPC bug fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-289: trident DRPC bug fix
Posted by davidlgr <gi...@git.apache.org>.
Github user davidlgr commented on the pull request:
https://github.com/apache/incubator-storm/pull/82#issuecomment-41165219
@d2r it's done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-289: trident DRPC bug fix
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/82#issuecomment-41176242
+1, tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---