You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Marcel Reutegger <mr...@adobe.com> on 2015/09/10 09:19:40 UTC
Oak 1.3.6 release plan
Hi,
I plan to release 1.3.6 on Monday. And this time I really hope
I will have the time to actually perform the release. Thanks
Amit for taking care of the previous 1.3.5 release!
We currently have 86 issues scheduled for the release [0]. This
is roughly twice as many we had pending before the 1.3.5 release.
I assume this is because we recently grouped issues into themes
and scheduled them rather tightly. Please adjust fix versions
for issues you are familiar with already before the release
on Monday.
There are currently two critical issue unresolved for 1.3.6:
- OAK-2835: TARMK Cold Standby inefficient cleanup
- OAK-3235: Deadlock when closing a concurrently used FileStore
Please resolve or reschedule issues until Monday or let me know
if you need more time for a release blocking issue.
Regards
Marcel
[0] https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%201.3.6%20AND%20project%20%3D%20OAK%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC
Re: Oak 1.3.6 release plan
Posted by Tomek Rekawek <re...@adobe.com>.
Hello,
Can I ask some committer to merge two issues before the release?
OAK-3148
Allows to migrate one blobstore to another during normal Oak operations. Already reviewed by the Thomas Mueller.
OAK-2171
The command line interface for all the upgrade/sidegrade features in Oak with a bunch of unit tests.
Thanks,
Tomek
On 10/09/15 09:19, "Marcel Reutegger" <mr...@adobe.com> wrote:
>Hi,
>
>I plan to release 1.3.6 on Monday. And this time I really hope
>I will have the time to actually perform the release. Thanks
>Amit for taking care of the previous 1.3.5 release!
>
>We currently have 86 issues scheduled for the release [0]. This
>is roughly twice as many we had pending before the 1.3.5 release.
>I assume this is because we recently grouped issues into themes
>and scheduled them rather tightly. Please adjust fix versions
>for issues you are familiar with already before the release
>on Monday.
>
>There are currently two critical issue unresolved for 1.3.6:
>
>- OAK-2835: TARMK Cold Standby inefficient cleanup
>- OAK-3235: Deadlock when closing a concurrently used FileStore
>
>Please resolve or reschedule issues until Monday or let me know
>if you need more time for a release blocking issue.
>
>Regards
>Marcel
>
>[0] https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%201.3.6%20AND%20project%20%3D%20OAK%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC
Re: Oak 1.3.6 release plan
Posted by Davide Giannella <da...@apache.org>.
On 11/09/2015 13:30, Julian Reschke wrote:
> On 2015-09-10 09:19, Marcel Reutegger wrote:
>> Hi,
>>
>> I plan to release 1.3.6 on Monday. And this time I really hope
>> I will have the time to actually perform the release. Thanks
>> Amit for taking care of the previous 1.3.5 release!
>> ...
>
> Given the amount of breakage we currently have because of OAK-3390
> (triggered by the introduction of the LeaseCheckDocumentWrapper), I'm
> not sure it makes sense to make a release right now.
No strong opinion on cancelling the release or keeping it on track; but
it's an unstable release. The added value of releasing it would be that
we could get faster feedbacks and bug report from anyone using it for
development of products to come.
Davide
Re: Oak 1.3.6 release plan
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
I assume the second issue is:
https://issues.apache.org/jira/browse/OAK-3389
please note, this is now a new problem. The instanceof
check would fail already before when one of the other
wrappers was enabled (logging or timing).
Regards
Marcel
On 14/09/15 09:51, "Marcel Reutegger" wrote:
>Hi,
>
>On 14/09/15 09:42, "Julian Reschke" wrote:
>>On 2015-09-14 09:17, Marcel Reutegger wrote:
>>> are things really broken because of the LeaseCheckDocumentWrapper?
>>> AFAIU it means the DocumentNodeStore will currently fall back
>>> to a generic implementation for getReferencedBlobsIterator(),
>>> which works but may be less efficient than the Mongo custom
>>> implementation.
>>Tests are broken (they don't test anymore what they are supposed to
>>test). Diagnostics in oak-run are broken (for RDB), because they can't
>>properly report about table cleanup anymore.
>
>the first one is tracked with OAK-3390 and I'm fine with a
>release that has this known issue.
>
>do we have a JIRA issue for the second problem already? would it
>make sense to just disable the lease check for the diagnostics
>in oak-run?
>
>Regards
> Marcel
>
Re: Oak 1.3.6 release plan
Posted by Stefan Egli <st...@apache.org>.
As the 1.3.6 is already in the voting phase, it would mean -1 for that
release - not sure if it's enough of an issue for that though? (mind you,
the issue was already there in 1.3.5..)
Cheers,
Stefan
On 14/09/15 12:29, "Julian Reschke" <ju...@gmx.de> wrote:
>On 2015-09-14 10:17, Julian Reschke wrote:
>> On 2015-09-14 10:03, Stefan Egli wrote:
>>> On 14/09/15 09:51, "Marcel Reutegger" <mr...@adobe.com> wrote:
>>>
>>>> ...would it
>>>> make sense to just disable the lease check for the diagnostics
>>>> in oak-run? ...
>>>
>>> +1 as a short-term fix
>>>
>>> Cheers,
>>> Stefan
>>
>> I agree that this would have been broken by the other wrappers, and the
>> approach in itself wasn't smart in the first place. My point being: can
>> we please come up with a proper solution that will address all the uses
>> cases?
>>
>> Best regards, Julian
>
>...essentially we are introducing a new feature (improving resilience)
>that breaks existing code assumptions, potentially causing performance
>degradations. I believe the right thing to do *now* is to disable the
>new feature, make the 1.3.6 release, then fix things properly and turn
>it in in 1.3.7.
>
>
>Best regards, Julian
>
>
>
>
>
>
>
>
Re: Oak 1.3.6 release plan
Posted by Julian Reschke <ju...@gmx.de>.
On 2015-09-14 10:17, Julian Reschke wrote:
> On 2015-09-14 10:03, Stefan Egli wrote:
>> On 14/09/15 09:51, "Marcel Reutegger" <mr...@adobe.com> wrote:
>>
>>> ...would it
>>> make sense to just disable the lease check for the diagnostics
>>> in oak-run? ...
>>
>> +1 as a short-term fix
>>
>> Cheers,
>> Stefan
>
> I agree that this would have been broken by the other wrappers, and the
> approach in itself wasn't smart in the first place. My point being: can
> we please come up with a proper solution that will address all the uses
> cases?
>
> Best regards, Julian
...essentially we are introducing a new feature (improving resilience)
that breaks existing code assumptions, potentially causing performance
degradations. I believe the right thing to do *now* is to disable the
new feature, make the 1.3.6 release, then fix things properly and turn
it in in 1.3.7.
Best regards, Julian
Re: Oak 1.3.6 release plan
Posted by Julian Reschke <ju...@greenbytes.de>.
On 2015-09-14 10:03, Stefan Egli wrote:
> On 14/09/15 09:51, "Marcel Reutegger" <mr...@adobe.com> wrote:
>
>> ...would it
>> make sense to just disable the lease check for the diagnostics
>> in oak-run? ...
>
> +1 as a short-term fix
>
> Cheers,
> Stefan
I agree that this would have been broken by the other wrappers, and the
approach in itself wasn't smart in the first place. My point being: can
we please come up with a proper solution that will address all the uses
cases?
Best regards, Julian
Re: Oak 1.3.6 release plan
Posted by Stefan Egli <st...@apache.org>.
On 14/09/15 09:51, "Marcel Reutegger" <mr...@adobe.com> wrote:
>...would it
>make sense to just disable the lease check for the diagnostics
>in oak-run? ...
+1 as a short-term fix
Cheers,
Stefan
Re: Oak 1.3.6 release plan
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
On 14/09/15 09:42, "Julian Reschke" wrote:
>On 2015-09-14 09:17, Marcel Reutegger wrote:
>> are things really broken because of the LeaseCheckDocumentWrapper?
>> AFAIU it means the DocumentNodeStore will currently fall back
>> to a generic implementation for getReferencedBlobsIterator(),
>> which works but may be less efficient than the Mongo custom
>> implementation.
>Tests are broken (they don't test anymore what they are supposed to
>test). Diagnostics in oak-run are broken (for RDB), because they can't
>properly report about table cleanup anymore.
the first one is tracked with OAK-3390 and I'm fine with a
release that has this known issue.
do we have a JIRA issue for the second problem already? would it
make sense to just disable the lease check for the diagnostics
in oak-run?
Regards
Marcel
Re: Oak 1.3.6 release plan
Posted by Julian Reschke <ju...@greenbytes.de>.
On 2015-09-14 09:17, Marcel Reutegger wrote:
> Hi,
>
> are things really broken because of the LeaseCheckDocumentWrapper?
> AFAIU it means the DocumentNodeStore will currently fall back
> to a generic implementation for getReferencedBlobsIterator(),
> which works but may be less efficient than the Mongo custom
> implementation.
>
> Regards
> Marcel
Tests are broken (they don't test anymore what they are supposed to
test). Diagnostics in oak-run are broken (for RDB), because they can't
properly report about table cleanup anymore.
Best regards, Julian
Re: Oak 1.3.6 release plan
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
are things really broken because of the LeaseCheckDocumentWrapper?
AFAIU it means the DocumentNodeStore will currently fall back
to a generic implementation for getReferencedBlobsIterator(),
which works but may be less efficient than the Mongo custom
implementation.
Regards
Marcel
On 11/09/15 14:30, "Julian Reschke" wrote:
>On 2015-09-10 09:19, Marcel Reutegger wrote:
>> Hi,
>>
>> I plan to release 1.3.6 on Monday. And this time I really hope
>> I will have the time to actually perform the release. Thanks
>> Amit for taking care of the previous 1.3.5 release!
>> ...
>
>Given the amount of breakage we currently have because of OAK-3390
>(triggered by the introduction of the LeaseCheckDocumentWrapper), I'm
>not sure it makes sense to make a release right now.
>
>Best regards, Julian
Re: Oak 1.3.6 release plan
Posted by Julian Reschke <ju...@gmx.de>.
On 2015-09-10 09:19, Marcel Reutegger wrote:
> Hi,
>
> I plan to release 1.3.6 on Monday. And this time I really hope
> I will have the time to actually perform the release. Thanks
> Amit for taking care of the previous 1.3.5 release!
> ...
Given the amount of breakage we currently have because of OAK-3390
(triggered by the introduction of the LeaseCheckDocumentWrapper), I'm
not sure it makes sense to make a release right now.
Best regards, Julian