You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/01 02:20:49 UTC
[GitHub] [incubator-yunikorn-core] craigcondit opened a new pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
craigcondit opened a new pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377
### What is this PR for?
Fixes a deadlock in Application.notifyRMAlloocationReleased().
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1099
### How should this be tested?
Updated tests and deadlock no longer occurs when run in real scheduler.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054919205
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0d87a8) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
> :exclamation: Current head e0d87a8 differs from pull request most recent head ddeb65a. Consider uploading reports for the commit ddeb65a to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9364 +10
=======================================
+ Hits 6487 6494 +7
- Misses 2625 2627 +2
- Partials 242 243 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.50% <70.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...ddeb65a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1056562159
>I am not sure whether I communicated clearly. Just to make it explicit, I meant, application#notifyRMAllocationReleased() and context#notifyRMAllocationReleased() methods.
The two duplicate functions cannot be avoided. The application is in a sub package from the scheduler, objects. The scheduler imports that package. That means the application cannot contain the context. To do that would mean importing the scheduler package. That is a circular dependency.
That dependency is worked around by keeping a reference to the RMEventHandler in the application.
> Also, Should we need to clear cache in case of RMReleaseAllocationAskEvent events (application#notifyRMAllocationAskReleased() )?
An ask is a pod that has not been scheduled yet. So it is a "new" pod that was created. That pod might or might not be in the cache just yet. It surely is not linked to a node. The only way that a pod is normally removed in that state is if it comes from the shim to the core. The only exception is a placeholder timeout. A placeholder that has not been placed on a node.
We should not be leaving anything around at the moment in the cache. Even for placeholders that timeout we clean up including the caches through the placeholder manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1056602756
Got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] craigcondit commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1055610489
> @craigcondit Thanks. I am wondering why ReSyncSchedulerCache was not being called in this context earlier? But I think it should have been called even before. Right? Did we missed this even before? @wilfred-s
It's possible this was a miss before, but the new logic after the core->shim refactoring creates a deadlock and stops the scheduler cold. That's what this PR addresses.
> Also, Should we need to clear cache in case of RMReleaseAllocationAskEvent events (application#notifyRMAllocationAskReleased() )?
I think given the scheduler interface is meant to be generic, it's important to let the shim process these events, whether or not it requires them. We don't really "clear the cache" per se on any of them, we just update the state to reflect what's in the core.
> Changes look good. Should we create a separate jira to refactor (or avoid duplicating) this method?
I'm not 100% sure a refactoring is needed, but if so, let's do a follow-up JIRA. If the changes look good, can you add a +1?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] craigcondit closed pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054919205
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddeb65a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9364 +10
=======================================
+ Hits 6487 6494 +7
- Misses 2625 2627 +2
- Partials 242 243 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.50% <70.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...ddeb65a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] craigcondit commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054917000
@manirajv06 can you take a look? This appears to have been a miss in YUNIKORN-462.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054919205
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d6eef1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9364 +10
=======================================
+ Hits 6487 6494 +7
- Misses 2625 2627 +2
- Partials 242 243 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.50% <70.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...7d6eef1](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] craigcondit edited a comment on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
craigcondit edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1055610489
> @craigcondit Thanks. I am wondering why ReSyncSchedulerCache was not being called in this context earlier? But I think it should have been called even before. Right? Did we missed this even before? @wilfred-s
It's possible this was a miss before, but the new logic after the core->shim refactoring creates a deadlock and stops the scheduler cold. That's what this PR addresses.
> Also, Should we need to clear cache in case of RMReleaseAllocationAskEvent events (application#notifyRMAllocationAskReleased() )?
I think given the scheduler interface is meant to be generic, it's important to let the shim process these events, whether or not it requires them. We don't really "clear the cache" per se on any of them, we just update the state to reflect what's in the core.
> Changes look good. Should we create a separate jira to refactor (or avoid duplicating) this method?
I'm not 100% sure a refactoring is needed, but if so, let's do a follow-up JIRA. Despite the similar names, allocations and asks are entirely separate concepts / events and need to be handled discretely.
If the changes look good, can you add a +1?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1056428988
+1 for the changes.
> I'm not 100% sure a refactoring is needed, but if so, let's do a follow-up JIRA. Despite the similar names, allocations and asks are entirely separate concepts / events and need to be handled discretely.
I am not sure whether I communicated clearly. Just to make it explicit, I meant, application#notifyRMAllocationReleased() and context#notifyRMAllocationReleased() methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054919205
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0d87a8) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9364 +10
=======================================
+ Hits 6487 6494 +7
- Misses 2625 2627 +2
- Partials 242 243 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.50% <70.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...e0d87a8](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1054919205
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#377](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddeb65a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `70.00%`.
> :exclamation: Current head ddeb65a differs from pull request most recent head 7d6eef1. Consider uploading reports for the commit 7d6eef1 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9364 +10
=======================================
+ Hits 6487 6494 +7
- Misses 2625 2627 +2
- Partials 242 243 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.50% <70.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...7d6eef1](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org