[GitHub] [ignite] ivandasch commented on a change in pull request #9754: IGNITE-16320 [ducktests] Do not override JVM options passed to IgniteApplicationService

[GitBox <gi...@apache.org>]

ivandasch commented on a change in pull request #9754:
URL: https://github.com/apache/ignite/pull/9754#discussion_r803382808



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -76,30 +76,50 @@ class IgniteSpec(metaclass=ABCMeta):
     This class is a basic Spec
     """
 
-    def __init__(self, service, jvm_opts, full_jvm_opts):
+    def __init__(self, service, jvm_opts=None, full_jvm_opts=None):

Review comment:
       May be sth like this?
   ```
   def __init__(self, service, extra_jvm_opts=None, jvm_opts=None):
   ```
   Also, may be good idea to raise exception if both of them is set, assertions may be ignored in certain circumstances.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org