You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/01/20 13:31:52 UTC
[GitHub] spark pull request #18277: [SPARK-20947][PYTHON] Fix encoding/decoding error...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18277#discussion_r162782791
--- Diff: python/pyspark/rdd.py ---
@@ -751,7 +751,7 @@ def func(iterator):
def pipe_objs(out):
for obj in iterator:
- s = str(obj).rstrip('\n') + '\n'
+ s = unicode(obj).rstrip('\n') + '\n'
--- End diff --
@chaoslawful, if you are active, we could change `\n` to `u\n` to reduce the conversion and don't rely on the implicit conversion between `str` and `unicode`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org