You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/07/06 15:44:34 UTC

[GitHub] [arrow] wgtmac opened a new pull request, #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

wgtmac opened a new pull request, #36504:
URL: https://github.com/apache/arrow/pull/36504

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] wjones127 commented on a diff in pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on code in PR #36504:
URL: https://github.com/apache/arrow/pull/36504#discussion_r1254711548


##########
.github/CODEOWNERS:
##########
@@ -29,13 +29,14 @@
 /c_glib/ @kou
 # /cpp/
 /cpp/src/arrow/acero @westonpace
+/cpp/src/arrow/adapters/orc @wgtmac
 /cpp/src/arrow/dataset @westonpace
 /cpp/src/arrow/engine @westonpace
 /cpp/src/arrow/flight/ @lidavidm
 /cpp/src/arrow/util/async* @westonpace
 /cpp/src/arrow/util/future* @westonpace
 /cpp/src/arrow/util/thread* @westonpace
-/cpp/src/parquet @wjones127
+/cpp/src/parquet @wjones127 @wgtmac

Review Comment:
   ```suggestion
   /cpp/src/parquet @wgtmac
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #36504:
URL: https://github.com/apache/arrow/pull/36504#discussion_r1254633101


##########
.github/CODEOWNERS:
##########
@@ -29,13 +29,14 @@
 /c_glib/ @kou
 # /cpp/
 /cpp/src/arrow/acero @westonpace
+/cpp/src/arrow/adapters/orc @wgtmac
 /cpp/src/arrow/dataset @westonpace
 /cpp/src/arrow/engine @westonpace
 /cpp/src/arrow/flight/ @lidavidm
 /cpp/src/arrow/util/async* @westonpace
 /cpp/src/arrow/util/future* @westonpace
 /cpp/src/arrow/util/thread* @westonpace
-/cpp/src/parquet @wjones127
+/cpp/src/parquet @wjones127 @wgtmac

Review Comment:
   @wjones127 Do you still want to be listed here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] wgtmac commented on a diff in pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #36504:
URL: https://github.com/apache/arrow/pull/36504#discussion_r1254635190


##########
.github/CODEOWNERS:
##########
@@ -29,13 +29,14 @@
 /c_glib/ @kou
 # /cpp/
 /cpp/src/arrow/acero @westonpace
+/cpp/src/arrow/adapters/orc @wgtmac
 /cpp/src/arrow/dataset @westonpace
 /cpp/src/arrow/engine @westonpace
 /cpp/src/arrow/flight/ @lidavidm
 /cpp/src/arrow/util/async* @westonpace
 /cpp/src/arrow/util/future* @westonpace
 /cpp/src/arrow/util/thread* @westonpace
-/cpp/src/parquet @wjones127
+/cpp/src/parquet @wjones127 @wgtmac

Review Comment:
   Feel free to directly edit this line. @wjones127 @pitrou 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36504:
URL: https://github.com/apache/arrow/pull/36504#issuecomment-1634397724

   Conbench analyzed the 6 benchmark runs on commit `42d8b01b`.
   
   There were 5 benchmark results indicating a performance regression:
   
   - Commit Run on `ursa-i9-9960x` at [2023-07-13 11:50:05Z](http://conbench.ursa.dev/compare/runs/f149a83b5217473c863a4ba057bc43ea...f1fa2df28d1b4b388df717743af4b36b/)
     - [compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, language=R, output_type=table](http://conbench.ursa.dev/compare/benchmarks/064afccd5d71731a80000e0c032e196e...064aff86353c73538000692888b376e1)
     - [compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, language=R, output_type=dataframe](http://conbench.ursa.dev/compare/benchmarks/064afcce1e03781080004fb0650c2179...064aff8749fb7bf48000a2005e1bda91)
   - and 3 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/15017857028) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] wgtmac commented on pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #36504:
URL: https://github.com/apache/arrow/pull/36504#issuecomment-1623905328

   cc @pitrou 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou merged pull request #36504: MINOR: [Dev] Add Gang Wu to CODEOWNERS for cpp/parquet and cpp/orc

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36504:
URL: https://github.com/apache/arrow/pull/36504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org