You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2013/09/24 10:31:06 UTC
[jira] [Commented] (OAK-658) Unexpected illegal path handling on
oak-jcr wrt backwards compatibility
[ https://issues.apache.org/jira/browse/OAK-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776123#comment-13776123 ]
Michael Dürig commented on OAK-658:
-----------------------------------
[~alexparvulescu] do you remember the related Sling discussion/issue and the outcome?
Otherwise I suggest to resolve this by adapting the expectations of the ignored tests. After all, returning null complies with the {{PathMapper}} contract and its clients might be in a better position to handle failures in paths parsing.
> Unexpected illegal path handling on oak-jcr wrt backwards compatibility
> -----------------------------------------------------------------------
>
> Key: OAK-658
> URL: https://issues.apache.org/jira/browse/OAK-658
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: jcr
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Attachments: SessionDelegate.java.patch
>
>
> Given an illegal path like ' * ' oak-core throws an
> bq. java.lang.IllegalArgumentException: Invalid path: /GetStarTest1361806728422/*
> which may confuse clients of oak-jcr (like sling) which expect to see a RepositoryException.
> I've seen this on the sling integration test
> bq. org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest.testCreatingNodeUnderFile
> which issues a get request for /GetStarTest1361806728422/*.12.json
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira