You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pd...@apache.org on 2020/08/28 11:52:39 UTC
[zeppelin] 01/13: The maven-frontend-plugin works better with an
absolute path. A relative path in the PATH environment variable can be
problematic.
This is an automated email from the ASF dual-hosted git repository.
pdallig pushed a commit to branch test_refactoring
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
commit 2b13a0e998b3b5086682677fa9e51d0e7bb0ab95
Author: Philipp Dallig <ph...@gmail.com>
AuthorDate: Thu Aug 27 13:42:59 2020 +0200
The maven-frontend-plugin works better with an absolute path. A relative path in the PATH environment variable can be problematic.
---
.../src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java | 2 +-
.../test/java/org/apache/zeppelin/helium/HeliumBundleFactoryTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
index fb419fb..3beba56 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumBundleFactory.java
@@ -109,7 +109,7 @@ public class HeliumBundleFactory {
@Inject
public HeliumBundleFactory(ZeppelinConfiguration conf) {
this.heliumLocalRepoDirectory =
- new File(conf.getRelativeDir(ConfVars.ZEPPELIN_DEP_LOCALREPO), HELIUM_LOCAL_REPO);
+ new File(conf.getRelativeDir(ConfVars.ZEPPELIN_DEP_LOCALREPO), HELIUM_LOCAL_REPO).getAbsoluteFile();
this.heliumBundleDirectory = new File(heliumLocalRepoDirectory, HELIUM_BUNDLES_DIR);
this.heliumLocalModuleDirectory = new File(heliumLocalRepoDirectory, HELIUM_LOCAL_MODULE_DIR);
this.yarnCacheDir = new File(heliumLocalRepoDirectory, YARN_CACHE_DIR);
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/helium/HeliumBundleFactoryTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/helium/HeliumBundleFactoryTest.java
index 3428c95..d47fead 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/helium/HeliumBundleFactoryTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/helium/HeliumBundleFactoryTest.java
@@ -48,7 +48,7 @@ public class HeliumBundleFactoryTest {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
nodeInstallationDir =
- new File(conf.getRelativeDir(ConfVars.ZEPPELIN_DEP_LOCALREPO), HELIUM_LOCAL_REPO);
+ new File(conf.getRelativeDir(ConfVars.ZEPPELIN_DEP_LOCALREPO), HELIUM_LOCAL_REPO).getAbsoluteFile();
hbf = new HeliumBundleFactory(conf);
hbf.installNodeAndNpm();
hbf.copyFrameworkModulesToInstallPath(true);