You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 03:28:25 UTC

[GitHub] [arrow] cyb70289 commented on pull request #8466: ARROW-10304: [C++][Compute] Optimize variance kernel for integers

cyb70289 commented on pull request #8466:
URL: https://github.com/apache/arrow/pull/8466#issuecomment-708872803


   **NOTE:** Benchmark PR https://github.com/apache/arrow/pull/8407 is not merged yet. Need to manually pull that PR to evaluation performance.
   
   Tested on Xeon Gold 5218, clang-9.
   
   ```
                                benchmark         baseline        contender  change %
   8        VarianceKernelInt32/1048576/0    1.798 GiB/sec    6.742 GiB/sec   274.842   'null_percent': 0.0
   18   VarianceKernelInt32/1048576/10000    1.742 GiB/sec    5.155 GiB/sec   195.990  'null_percent': 0.01
   6      VarianceKernelInt32/1048576/100    1.135 GiB/sec    2.806 GiB/sec   147.285   'null_percent': 1.0
   7       VarianceKernelInt32/1048576/10  858.921 MiB/sec    1.551 GiB/sec    84.901  'null_percent': 10.0
   19       VarianceKernelInt32/1048576/2  456.209 MiB/sec  771.633 MiB/sec    69.140  'null_percent': 50.0
   12       VarianceKernelFloat/1048576/2  396.262 MiB/sec  455.307 MiB/sec    14.900  'null_percent': 50.0
   14       VarianceKernelFloat/1048576/1    1.095 TiB/sec    1.210 TiB/sec    10.563  null_percent': 100.0
   3       VarianceKernelFloat/1048576/10  788.471 MiB/sec  857.623 MiB/sec     8.770  'null_percent': 10.0
   15      VarianceKernelDouble/1048576/1    1.152 TiB/sec    1.213 TiB/sec     5.312  null_percent': 100.0
   1        VarianceKernelInt32/1048576/1    1.200 TiB/sec    1.259 TiB/sec     4.901  null_percent': 100.0
   23     VarianceKernelFloat/1048576/100    1.129 GiB/sec    1.134 GiB/sec     0.371   'null_percent': 1.0
   4       VarianceKernelDouble/1048576/0    3.580 GiB/sec    3.587 GiB/sec     0.195   'null_percent': 0.0
   20       VarianceKernelFloat/1048576/0    1.798 GiB/sec    1.800 GiB/sec     0.090   'null_percent': 0.0
   10   VarianceKernelFloat/1048576/10000    1.743 GiB/sec    1.743 GiB/sec     0.006  'null_percent': 0.01
   2    VarianceKernelInt64/1048576/10000    3.468 GiB/sec    3.468 GiB/sec    -0.005  'null_percent': 0.01
   17       VarianceKernelInt64/1048576/0    3.586 GiB/sec    3.584 GiB/sec    -0.050   'null_percent': 0.0
   0   VarianceKernelDouble/1048576/10000    3.476 GiB/sec    3.474 GiB/sec    -0.066  'null_percent': 0.01
   11    VarianceKernelDouble/1048576/100    2.276 GiB/sec    2.274 GiB/sec    -0.122   'null_percent': 1.0
   5      VarianceKernelInt64/1048576/100    2.274 GiB/sec    2.269 GiB/sec    -0.227   'null_percent': 1.0
   22     VarianceKernelDouble/1048576/10    1.652 GiB/sec    1.604 GiB/sec    -2.856  'null_percent': 10.0
   21       VarianceKernelInt64/1048576/1    1.242 TiB/sec    1.206 TiB/sec    -2.919  null_percent': 100.0
   13      VarianceKernelDouble/1048576/2  864.392 MiB/sec  832.143 MiB/sec    -3.731  'null_percent': 50.0
   16      VarianceKernelInt64/1048576/10    1.681 GiB/sec    1.546 GiB/sec    -8.006  'null_percent': 10.0
   9        VarianceKernelInt64/1048576/2  910.548 MiB/sec  786.507 MiB/sec   -13.623  'null_percent': 50.0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org