You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/06/03 19:13:48 UTC

[GitHub] [orc] belugabehr opened a new pull request #708: ORC-806: Upgrade to Apache POM 23

belugabehr opened a new pull request #708:
URL: https://github.com/apache/orc/pull/708


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of describing the problem.
     3. Make PR title and description complete because these will be the permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   Upgrade Apache Parent POM to version 23 and clean up superfluous Maven POM elements
   
   
   ### Why are the changes needed?
   Get benefits from upgraded maven plugins. Simplification.
   
   
   ### How was this patch tested?
   Existing unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-886376945


   Hi, All.
   I'll backport this and https://github.com/apache/orc/pull/753 to `branch-1.7` for Apache ORC 1.7.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-871579979


   Welcome back! Thank you so much for updating, @belugabehr .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r645176034



##########
File path: java/pom.xml
##########
@@ -17,7 +17,7 @@
   <parent>
     <groupId>org.apache</groupId>
     <artifactId>apache</artifactId>
-    <version>18</version>
+    <version>23</version>

Review comment:
       Oh, yes. I did for this at ORC-796, but actually missed this.
   - https://github.com/apache/orc/commit/f0f2e1847348333a44aa69e1c6e878b4d76e0d8e#diff-d8225ebcfc11b480a6e4f54e183b67c3ead51635a167c106d928c2abf1f9ef66




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r671914990



##########
File path: java/tools/pom.xml
##########
@@ -82,7 +80,6 @@
     <dependency>
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
-      <scope>compile</scope>

Review comment:
       This one is also required.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-871584898


   Thank you for your contribution again, @belugabehr . After I check this commit's status on `main` branch, I'll backport it to branch-1.7 for Apache ORC 1.7.0. In addition, we are currently releasing Apache ORC 1.6.9. You can participate the vote.
   - https://lists.apache.org/thread.html/rab78879c2ff44b0357d49b592974545d5e649852c53a696510e19bdd%40%3Cdev.orc.apache.org%3E


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-871404922


   @dongjoon-hyun Hey. I'm back.  I just merged and built locally.  We shall see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r645176034



##########
File path: java/pom.xml
##########
@@ -17,7 +17,7 @@
   <parent>
     <groupId>org.apache</groupId>
     <artifactId>apache</artifactId>
-    <version>18</version>
+    <version>23</version>

Review comment:
       Oh, yes. I did for this at ORC-796, but actually missed this.
   - https://github.com/apache/orc/commit/f0f2e1847348333a44aa69e1c6e878b4d76e0d8e#diff-d8225ebcfc11b480a6e4f54e183b67c3ead51635a167c106d928c2abf1f9ef66




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-871573857


   @dongjoon-hyun Should be good to go now.  Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #708:
URL: https://github.com/apache/orc/pull/708


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r681444050



##########
File path: java/examples/pom.xml
##########
@@ -50,14 +50,10 @@
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
-      <version>${hadoop.version}</version>
-      <scope>compile</scope>

Review comment:
       This causes another regression. https://github.com/apache/orc/pull/808 aims to fix this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-869196903


   I resolved the conflicts for you, @belugabehr .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on a change in pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #708:
URL: https://github.com/apache/orc/pull/708#discussion_r671914934



##########
File path: java/tools/pom.xml
##########
@@ -58,13 +58,11 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <version>${tools.hadoop.version}</version>
-      <scope>compile</scope>

Review comment:
       Hi, @belugabehr and @dongjoon-hyun .
   This seems to break ORC tools uber jar again. I'll make a PR to recover it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-869062813


   Gentle ping, @belugabehr .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #708: ORC-806: Upgrade to Apache POM 23

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #708:
URL: https://github.com/apache/orc/pull/708#issuecomment-882138264


   Oh. My bad. Thank you, @williamhyun .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org