You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:21:09 UTC

[GitHub] [flink] xintongsong opened a new pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

xintongsong opened a new pull request #15095:
URL: https://github.com/apache/flink/pull/15095


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6695d2b5d4fe378852161df5caddb98a4a94efec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193) 
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   * 325d135d6dc336417ae6e50b616fd3a801b49769 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283) 
   * 0f986eaa748171f1a7985fb61934dc6c48a4b557 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589252926



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -228,7 +228,7 @@ private void recoverWorkerNodesFromPreviousAttempts() throws ResourceManagerExce
                 currentMaxAttemptId = attempt;
             }
 
-            if (pod.isTerminated()) {
+            if (pod.isTerminated() || !pod.isScheduled()) {

Review comment:
       Make sense. We could have a dedicated ticket for this issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   * 325d135d6dc336417ae6e50b616fd3a801b49769 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589245658



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1200,7 +1202,7 @@ public void grantLeadership(final UUID newLeaderSessionID) {
 
             startServicesOnLeadership();
 
-            return prepareLeadershipAsync().thenApply(ignored -> true);
+            return prepareLeadershipAsync().thenApply(ignored -> hasLeadership = true);

Review comment:
       I'm setting `hasLeadership` to `true` here because this is the last step in the rpc main thread. Confirming leadership happens on the io thread, and should trigger fatal error shutdown once failed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292",
       "triggerID" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f986eaa748171f1a7985fb61934dc6c48a4b557 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589252926



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -228,7 +228,7 @@ private void recoverWorkerNodesFromPreviousAttempts() throws ResourceManagerExce
                 currentMaxAttemptId = attempt;
             }
 
-            if (pod.isTerminated()) {
+            if (pod.isTerminated() || !pod.isScheduled()) {

Review comment:
       Make sense. We could have a dedicated ticket for this issue. Only when the leader is granted for ResourceManager, we need to recover the pods from latest attempt and create the watch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292",
       "triggerID" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   * 325d135d6dc336417ae6e50b616fd3a801b49769 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283) 
   * 0f986eaa748171f1a7985fb61934dc6c48a4b557 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589227565



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1200,7 +1202,7 @@ public void grantLeadership(final UUID newLeaderSessionID) {
 
             startServicesOnLeadership();
 
-            return prepareLeadershipAsync().thenApply(ignored -> true);
+            return prepareLeadershipAsync().thenApply(ignored -> hasLeadership = true);

Review comment:
       Hmm. I think we could set `hasLeadership` to `true` after the `ResourceManager` confirms the leadership. Right?

##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -228,7 +228,7 @@ private void recoverWorkerNodesFromPreviousAttempts() throws ResourceManagerExce
                 currentMaxAttemptId = attempt;
             }
 
-            if (pod.isTerminated()) {
+            if (pod.isTerminated() || !pod.isScheduled()) {

Review comment:
       Out the scope of this PR, maybe we also should not stop the pod when the current `KubernetesResourceManagerDriver` is not the leader.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c96a63faf0b3dc03436738bfb4a973cba74757b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187) 
   * 6695d2b5d4fe378852161df5caddb98a4a94efec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c96a63faf0b3dc03436738bfb4a973cba74757b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187) 
   * 6695d2b5d4fe378852161df5caddb98a4a94efec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292",
       "triggerID" : "0f986eaa748171f1a7985fb61934dc6c48a4b557",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 325d135d6dc336417ae6e50b616fd3a801b49769 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283) 
   * 0f986eaa748171f1a7985fb61934dc6c48a4b557 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14292) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589146194



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesPod.java
##########
@@ -42,6 +43,17 @@ public boolean isTerminated() {
         return false;
     }
 
+    public boolean isScheduled() {
+        if (getInternalResource().getStatus() != null) {
+            return getInternalResource().getStatus().getConditions().stream()
+                    .anyMatch(
+                            e ->

Review comment:
       This is exactly correct after reading the documentation of Kubernetes[1].
   
   [1]. https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-conditions

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java
##########
@@ -235,6 +241,8 @@ public void onPreviousAttemptWorkersRecovered(Collection<WorkerType> recoveredWo
         for (WorkerType worker : recoveredWorkers) {
             final ResourceID resourceId = worker.getResourceID();
             workerNodeMap.put(resourceId, worker);
+            previousAttemptUnregisteredWorkers.add(resourceId);

Review comment:
       Since `onPreviousAttemptWorkersRecovered` is executed before the leadship is granted, do we have a chance that the standby JobManagers also want to stop/re-request the TaskManager pods? I think this is not the responsibility of standby JobManagers.

##########
File path: flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
##########
@@ -202,6 +202,20 @@
     public static final String CONTAINERIZED_TASK_MANAGER_ENV_PREFIX =
             "containerized.taskmanager.env.";
 
+    /** Timeout for TaskManagers to register at the active resource managers. */
+    public static final ConfigOption<Duration> TASK_MANAGER_REGISTRATION_TIMEOUT =
+            ConfigOptions.key("resourcemanager.taskmanager-registration.timeout")
+                    .durationType()
+                    .defaultValue(TaskManagerOptions.REGISTRATION_TIMEOUT.defaultValue())
+                    .withDeprecatedKeys(TaskManagerOptions.REGISTRATION_TIMEOUT.key())

Review comment:
       I think you means `withFallbackKeys` here. Right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6695d2b5d4fe378852161df5caddb98a4a94efec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193) 
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791287751


   cc @wangyang0918 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791289517


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c96a63faf0b3dc03436738bfb4a973cba74757b4 (Fri Mar 05 09:24:08 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c96a63faf0b3dc03436738bfb4a973cba74757b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187) 
   * 6695d2b5d4fe378852161df5caddb98a4a94efec UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271",
       "triggerID" : "55487801a298fe8c0aba7b246e4f1db7fd7eadc7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283",
       "triggerID" : "325d135d6dc336417ae6e50b616fd3a801b49769",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 55487801a298fe8c0aba7b246e4f1db7fd7eadc7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14271) 
   * 325d135d6dc336417ae6e50b616fd3a801b49769 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14283) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589181652



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java
##########
@@ -235,6 +241,8 @@ public void onPreviousAttemptWorkersRecovered(Collection<WorkerType> recoveredWo
         for (WorkerType worker : recoveredWorkers) {
             final ResourceID resourceId = worker.getResourceID();
             workerNodeMap.put(resourceId, worker);
+            previousAttemptUnregisteredWorkers.add(resourceId);

Review comment:
       That's a good point.
   
   I don't think a standby RM will re-request workers, because it only re-request workers when there are unfulfilled resource requirements, which a standby RM should not have since it doesn't accept any resource requirement until becoming the leader. However, it is indeed possible that the standby RM tries to stop the worker. I'll add a check to make sure it only tries to stop workers when it has the leadership.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589246950



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -228,7 +228,7 @@ private void recoverWorkerNodesFromPreviousAttempts() throws ResourceManagerExce
                 currentMaxAttemptId = attempt;
             }
 
-            if (pod.isTerminated()) {
+            if (pod.isTerminated() || !pod.isScheduled()) {

Review comment:
       It's also possible for the driver to try removing pods on receiving pod terminated events, which can also happen before obtaining the leadership.
   I'd suggest to fix this in a separate ticket.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on a change in pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #15095:
URL: https://github.com/apache/flink/pull/15095#discussion_r589339512



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -228,7 +228,7 @@ private void recoverWorkerNodesFromPreviousAttempts() throws ResourceManagerExce
                 currentMaxAttemptId = attempt;
             }
 
-            if (pod.isTerminated()) {
+            if (pod.isTerminated() || !pod.isScheduled()) {

Review comment:
       I've created FLINK-21667 for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14187",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193",
       "triggerID" : "6695d2b5d4fe378852161df5caddb98a4a94efec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6695d2b5d4fe378852161df5caddb98a4a94efec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14193) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong closed pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #15095:
URL: https://github.com/apache/flink/pull/15095


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-791301808


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c96a63faf0b3dc03436738bfb4a973cba74757b4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c96a63faf0b3dc03436738bfb4a973cba74757b4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xintongsong commented on pull request #15095: [FLINK-13554][runtime] Add a timeout for worker registration.

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #15095:
URL: https://github.com/apache/flink/pull/15095#issuecomment-792495223


   Thanks for the review, @wangyang0918. Comments addressed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org