[GitHub] [arrow] cyb70289 commented on a change in pull request #11383: ARROW-9688: Enable building c++ library and pyarrow package for win/arm64 build

[GitBox <gi...@apache.org>]

cyb70289 commented on a change in pull request #11383:
URL: https://github.com/apache/arrow/pull/11383#discussion_r726725678



##########
File path: cpp/src/arrow/util/bit_util.h
##########
@@ -18,8 +18,11 @@
 #pragma once
 
 #if defined(_MSC_VER)
+#if defined(_M_AMD64) || defined(_M_X64)
 #include <intrin.h>  // IWYU pragma: keep
 #include <nmmintrin.h>
+#endif

Review comment:
       So we don't need any header for arm64 intrinsics?

##########
File path: docs/source/developers/cpp/windows.rst
##########
@@ -286,6 +286,28 @@ file:
    make || exit /B
    popd
 
+Building on Windows/ARM64 using Ninja and Clang
+===============================================
+
+Ninja and LLVM toolchain (clang) can used for building library on windows/arm64 platform.
+
+.. code-block:: batch
+
+   cd cpp
+   mkdir build
+   cd build
+
+   set CC=clang-cl
+   set CXX=clang-cl
+
+   cmake -G "Ninja" ..

Review comment:
       Will you try building some basic modules and unit tests?
   E.g., `cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Debug -DARROW_COMPUTE=ON -DARROW_DATASET=ON -DARROW_BUILD_TESTS=ON ..`

##########
File path: docs/source/developers/cpp/windows.rst
##########
@@ -286,6 +286,28 @@ file:
    make || exit /B
    popd
 
+Building on Windows/ARM64 using Ninja and Clang
+===============================================
+
+Ninja and LLVM toolchain (clang) can used for building library on windows/arm64 platform.

Review comment:
       can used -> can *be* used ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org