You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2016/04/20 07:00:50 UTC

svn commit: r1740045 - in /tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

Author: kfujino
Date: Wed Apr 20 05:00:50 2016
New Revision: 1740045

URL: http://svn.apache.org/viewvc?rev=1740045&view=rev
Log:
Change the channel field to protected.

Modified:
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java
    tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java Wed Apr 20 05:00:50 2016
@@ -151,10 +151,10 @@ public class ChannelCoordinator extends
             //listens to with the local membership settings
             if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
                 clusterReceiver.setMessageListener(this);
-                clusterReceiver.setChannel(getChannel());
+                clusterReceiver.setChannel(channel);
                 clusterReceiver.start();
                 //synchronize, big time FIXME
-                Member localMember = getChannel().getLocalMember(false);
+                Member localMember = channel.getLocalMember(false);
                 if (localMember instanceof StaticMember) {
                     // static member
                     StaticMember staticMember = (StaticMember)localMember;
@@ -171,14 +171,14 @@ public class ChannelCoordinator extends
                 valid = true;
             }
             if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
-                clusterSender.setChannel(getChannel());
+                clusterSender.setChannel(channel);
                 clusterSender.start();
                 valid = true;
             }
 
             if ( Channel.MBR_RX_SEQ==(svc & Channel.MBR_RX_SEQ) ) {
                 membershipService.setMembershipListener(this);
-                membershipService.setChannel(getChannel());
+                membershipService.setChannel(channel);
                 if (membershipService instanceof McastService) {
                     ((McastService)membershipService).setMessageListener(this);
                 }
@@ -186,7 +186,7 @@ public class ChannelCoordinator extends
                 valid = true;
             }
             if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
-                membershipService.setChannel(getChannel());
+                membershipService.setChannel(channel);
                 membershipService.start(MembershipService.MBR_TX);
                 valid = true;
             }

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java Wed Apr 20 05:00:50 2016
@@ -29,7 +29,7 @@ public abstract class ChannelInterceptor
 
     private ChannelInterceptor next;
     private ChannelInterceptor previous;
-    private Channel channel;
+    protected Channel channel;
     //default value, always process
     protected int optionFlag = 0;
 

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java Wed Apr 20 05:00:50 2016
@@ -111,7 +111,7 @@ public class MessageDispatchInterceptor
             return;
         }
         String channelName = "";
-        if (getChannel().getName() != null) channelName = "[" + getChannel().getName() + "]";
+        if (channel.getName() != null) channelName = "[" + channel.getName() + "]";
         executor = ExecutorFactory.newThreadPool(maxSpareThreads, maxThreads, keepAliveTime,
                 TimeUnit.MILLISECONDS,
                 new TcclThreadFactory("MessageDispatchInterceptor.MessageDispatchThread" + channelName));

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java Wed Apr 20 05:00:50 2016
@@ -70,7 +70,7 @@ public class TcpPingInterceptor extends
             thread = new PingThread();
             thread.setDaemon(true);
             String channelName = "";
-            if (getChannel().getName() != null) channelName = "[" + getChannel().getName() + "]";
+            if (channel.getName() != null) channelName = "[" + channel.getName() + "]";
             thread.setName("TcpPingInterceptor.PingThread" + channelName +"-"+cnt.addAndGet(1));
             thread.start();
         }

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java Wed Apr 20 05:00:50 2016
@@ -78,7 +78,7 @@ public class McastService implements Mem
 
     protected byte[] domain;
 
-    private Channel channel;
+    protected Channel channel;
 
     /**
      * Create a membership service.

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java Wed Apr 20 05:00:50 2016
@@ -155,7 +155,7 @@ public class McastServiceImpl {
      */
     protected final boolean localLoopbackDisabled;
 
-    private Channel channel;
+    protected Channel channel;
 
     /**
      * Create a new mcast service instance.
@@ -620,7 +620,7 @@ public class McastServiceImpl {
 
             Thread t = new RecoveryThread(parent);
             String channelName = "";
-            if (parent.getChannel().getName() != null) channelName = "[" + parent.getChannel().getName() + "]";
+            if (parent.channel.getName() != null) channelName = "[" + parent.channel.getName() + "]";
             t.setName("Tribes-MembershipRecovery" + channelName);
             t.setDaemon(true);
             t.start();

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java Wed Apr 20 05:00:50 2016
@@ -80,7 +80,7 @@ public abstract class ReceiverBase imple
     private long maxIdleTime = 60000;
 
     private ExecutorService executor;
-    private Channel channel;
+    protected Channel channel;
 
     public ReceiverBase() {
     }

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java Wed Apr 20 05:00:50 2016
@@ -30,7 +30,7 @@ import org.apache.catalina.tribes.transp
  */
 public class ReplicationTransmitter implements ChannelSender {
 
-    private Channel channel;
+    protected Channel channel;
 
     public ReplicationTransmitter() {
     }

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java Wed Apr 20 05:00:50 2016
@@ -54,7 +54,7 @@ public class BioReceiver extends Receive
             getBind();
             bind();
             String channelName = "";
-            if (getChannel().getName() != null) channelName = "[" + getChannel().getName() + "]";
+            if (channel.getName() != null) channelName = "[" + channel.getName() + "]";
             Thread t = new Thread(this, "BioReceiver" + channelName);
             t.setDaemon(true);
             t.start();

Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java
URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java?rev=1740045&r1=1740044&r2=1740045&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java Wed Apr 20 05:00:50 2016
@@ -89,7 +89,7 @@ public class NioReceiver extends Receive
             getBind();
             bind();
             String channelName = "";
-            if (getChannel().getName() != null) channelName = "[" + getChannel().getName() + "]";
+            if (channel.getName() != null) channelName = "[" + channel.getName() + "]";
             Thread t = new Thread(this, "NioReceiver" + channelName);
             t.setDaemon(true);
             t.start();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org