You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/25 14:02:08 UTC

[GitHub] [spark] nicolasazrak commented on a change in pull request #34356: [SPARK-36554][PYTHON] Expose make_date expression in functions.scala

nicolasazrak commented on a change in pull request #34356:
URL: https://github.com/apache/spark/pull/34356#discussion_r735631614



##########
File path: python/pyspark/sql/tests/test_functions.py
##########
@@ -241,6 +241,14 @@ def test_dayofweek(self):
         row = df.select(dayofweek(df.date)).first()
         self.assertEqual(row[0], 2)
 
+    def test_make_date(self):
+        from pyspark.sql.functions import make_date

Review comment:
       Sure, I was only copying other tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org