You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/06 19:25:17 UTC

[GitHub] [couchdb] kocolosk opened a new pull request #2408: Bring IOQ in tree

kocolosk opened a new pull request #2408: Bring IOQ in tree
URL: https://github.com/apache/couchdb/pull/2408
 
 
   ## Overview
   
   This Pull Request brings a simplified version of the IO Queue subsystem into the mainline CouchDB repo. It ignores the larger IOQ contribution from the Cloudant team and instead adds a small patch to surface the API documented in apache/couchdb-documentation#464.
   
   ## Testing recommendations
   
   ## Related Issues or Pull Requests
   
   Commit e641a74 implements the API documented in apache/couchdb-documentation#464
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [x] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] kocolosk merged pull request #2408: Bring IOQ in tree

Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #2408: Bring IOQ in tree
URL: https://github.com/apache/couchdb/pull/2408
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] big-r81 commented on a change in pull request #2408: Bring IOQ in tree

Posted by GitBox <gi...@apache.org>.
big-r81 commented on a change in pull request #2408: Bring IOQ in tree
URL: https://github.com/apache/couchdb/pull/2408#discussion_r364615123
 
 

 ##########
 File path: rel/overlay/etc/default.ini
 ##########
 @@ -512,6 +512,40 @@ min_priority = 2.0
 [smoosh.ratio_views]
 min_priority = 2.0
 
+[ioq]
+; The maximum number of concurrent in-flight IO requests that
 
 Review comment:
   remove "that"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] kocolosk commented on a change in pull request #2408: Bring IOQ in tree

Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #2408: Bring IOQ in tree
URL: https://github.com/apache/couchdb/pull/2408#discussion_r364779069
 
 

 ##########
 File path: rel/overlay/etc/default.ini
 ##########
 @@ -512,6 +512,40 @@ min_priority = 2.0
 [smoosh.ratio_views]
 min_priority = 2.0
 
+[ioq]
+; The maximum number of concurrent in-flight IO requests that
 
 Review comment:
   Good catch, will address on the next change to the .ini file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services