You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/03/04 22:32:36 UTC

[GitHub] [knox] rlevas commented on a change in pull request #62: KNOX-474 - Added Kerberos related configuration validation at gateway startup time

rlevas commented on a change in pull request #62: KNOX-474 - Added Kerberos related configuration validation at gateway startup time
URL: https://github.com/apache/knox/pull/62#discussion_r262272344
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
 ##########
 @@ -174,7 +175,7 @@ GatewayServices getGatewayServices() {
     return services;
   }
 
-  private void initializeServices(boolean persisting) throws ServiceLifecycleException {
+  private void initializeServices(boolean persisting) throws ServiceLifecycleException, GatewayConfigurationException {
     GatewayConfig config = getGatewayConfig();
 
 Review comment:
   Does the KnoxCLI really need to fail here if the server's Kerberos config is not correct? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services