You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 09:59:47 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32167: [SPARK-35067][TESTS]Add test case for function COALESCE().

HyukjinKwon commented on a change in pull request #32167:
URL: https://github.com/apache/spark/pull/32167#discussion_r613933141



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -404,6 +404,9 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
     checkAnswer(
       sql("SELECT COALESCE(null, null, null)"),
       Row(null))
+    checkAnswer(
+      sql("SELECT COALESCE(s, n) FROM nullStrings"),

Review comment:
       I think this case is covered at least at `sql/core/src/test/resources/sql-tests/inputs/outer-join.sql`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org