You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "jpeach (via GitHub)" <gi...@apache.org> on 2023/08/07 05:41:41 UTC
[GitHub] [trafficserver] jpeach opened a new pull request, #10154: Fix Throttler initialization.
jpeach opened a new pull request, #10154:
URL: https://github.com/apache/trafficserver/pull/10154
Ensure that the Throttler last allowed time is zero-initialized. This field was uninitialized on macOS with clang 14, causing test failures.
Since we are here, we also switch the Throttler to use the chrono steady_clock (since we don't want it to jump during a throttle interval), and remove virtual functino annotations, since Throttler can't reasonably serve as a base clase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #10154: Fix Throttler initialization.
Posted by "randall (via GitHub)" <gi...@apache.org>.
randall commented on PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154#issuecomment-1668273965
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #10154: Fix Throttler initialization.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154#issuecomment-1668738769
`polite_hook_wait` appears to be a spurious failure @dragon512
```
./autest.sh --ats-bin=/opt/ats/bin --filter=polite_hook_wait
Python 3.6 or newer detected!
python3-dev/devel detected!
pipenv detected!
Using the pre-existing virtual environment.
Environment config finished. Running AuTest...
Running Test polite_hook_wait:... Passed
Generating Report: --------------
Total of 1 test
Unknown: 0
Exception: 0
Failed: 0
Warning: 0
Skipped: 0
Passed: 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #10154: Fix Throttler initialization.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154#issuecomment-1667657926
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach merged pull request #10154: Fix Throttler initialization.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach merged PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #10154: Fix Throttler initialization.
Posted by "randall (via GitHub)" <gi...@apache.org>.
randall commented on PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154#issuecomment-1668639161
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jpeach commented on pull request #10154: Fix Throttler initialization.
Posted by "jpeach (via GitHub)" <gi...@apache.org>.
jpeach commented on PR #10154:
URL: https://github.com/apache/trafficserver/pull/10154#issuecomment-1667283138
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org