[GitHub] [hive] kgyrtkirk commented on a change in pull request #1241: HIVE-22415: Upgrade to Java 11

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #1241:
URL: https://github.com/apache/hive/pull/1241#discussion_r461355075



##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java
##########
@@ -17,31 +17,17 @@
  */
 package org.apache.hadoop.hive.llap.cache;
 
-import java.lang.reflect.Field;
 import java.nio.ByteBuffer;
 
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.hive.common.io.Allocator;
 import org.apache.hadoop.hive.common.io.encoded.MemoryBuffer;
 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hadoop.hive.llap.io.api.impl.LlapIoImpl;
-
-import sun.misc.Cleaner;
+import org.apache.hive.common.util.CleanerUtil;

Review comment:
       I think it's mandatory to upgrade to at least
   https://issues.apache.org/jira/browse/HADOOP-15338 marks 3.3 for jdk11 support - I don't think we should try to run hive with hadoop 3.1 on jdk11...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org