[jira] [Commented] (BEAM-7933) Adding timeout to JobServer grpc calls

["Kyle Weaver (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936154#comment-16936154 ] 

Kyle Weaver commented on BEAM-7933:
-----------------------------------

I think this would be a useful feature, especially for common failure modes such as pipeline submission. Do you still plan on implementing this [~enricoc]?

> Adding timeout to JobServer grpc calls
> --------------------------------------
>
>                 Key: BEAM-7933
>                 URL: https://issues.apache.org/jira/browse/BEAM-7933
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>    Affects Versions: 2.14.0
>            Reporter: Enrico Canzonieri
>            Assignee: Enrico Canzonieri
>            Priority: Minor
>              Labels: portability
>
> grpc calls to the JobServer from the Python SDK do not have timeouts. That means that the call to pipeline.run()could hang forever if the JobServer is not running (or failing to start).
> E.g. [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/portable_runner.py#L307] the call to Prepare() doesn't provide any timeout value and the same applies to other JobServer requests.
> As part of this ticket we could add a default timeout of 60 seconds as the default timeout for http client.
> Additionally, we could consider adding a --job-server-request-timeout to the [PortableOptions|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/options/pipeline_options.py#L805] class to be used in the JobServer interactions inside probable_runner.py.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)