Re: [PR] Handle uninitialized cache in Node role watchers (druid)

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #15726:
URL: https://github.com/apache/druid/pull/15726#discussion_r1485790035


##########
server/src/main/java/org/apache/druid/curator/discovery/CuratorDruidNodeDiscoveryProvider.java:
##########
@@ -219,6 +227,17 @@ public void close() throws IOException
     @Override
     public Collection<DiscoveryDruidNode> getAllNodes()
     {
+      while (baseNodeRoleWatcher.getAllNodes() == null) {
+        log.warn("BaseNodeRoleWatcher could not return all nodes for role[%s]. Retrying with new cache.", nodeRole);
+        try {
+          cache.close();

Review Comment:
   FYI this would not close the executor because shutDownonExecutor is false. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org