You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2014/10/11 18:19:20 UTC
[3/3] git commit: ISIS-872: various minor stabilization bug fixes or
cosmetic fix.
ISIS-872: various minor stabilization bug fixes or cosmetic fix.
1. workaround for scrollbars showing up in action modal dialog in Chrome
2. PageAbstract, make the applicaton name theme resilient to non-valid characters in the application name
3. in publishing support class, allow for a null arg for published actions.
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/13eb2002
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/13eb2002
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/13eb2002
Branch: refs/heads/master
Commit: 13eb200238b522b4522a3b83d459304f596cabfc
Parents: 282a2f8
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Sat Oct 11 17:03:45 2014 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Sat Oct 11 17:12:28 2014 +0100
----------------------------------------------------------------------
.../actionprompt/ActionPromptModalWindow.java | 2 +-
.../viewer/wicket/ui/pages/PageAbstract.css | 2 +-
.../viewer/wicket/ui/pages/PageAbstract.java | 6 ++---
.../wicket/ui/pages/PageAbstractTest.java | 23 ++++++++++++++++++++
...shingServiceWithDefaultPayloadFactories.java | 3 +++
5 files changed, 31 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/13eb2002/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionprompt/ActionPromptModalWindow.java
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionprompt/ActionPromptModalWindow.java b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionprompt/ActionPromptModalWindow.java
index 742ece6..f53d560 100644
--- a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionprompt/ActionPromptModalWindow.java
+++ b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionprompt/ActionPromptModalWindow.java
@@ -113,7 +113,7 @@ public class ActionPromptModalWindow extends ModalWindow implements ActionPrompt
" ww.autoSizeWindow();\n " +
// this is a nasty hack to make dialog appear without scrollbars on Chrome (noticed in version 37.0.2062.120 m)
// really though this ought to be fixed in Wicket.Window.get().autoSizeWindow();
- " $('.actionPanel .myBlockContainer').css('margin', '19px');\n " +
+ " $('.actionPanel .myBlockContainer').css('margin', '19px').css('padding', '19px');\n " +
"}\n, 0);\n");
target.appendJavaScript(builder.toString());
http://git-wip-us.apache.org/repos/asf/isis/blob/13eb2002/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.css
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.css b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.css
index 6e53e6b..0870a16 100644
--- a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.css
+++ b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.css
@@ -754,7 +754,7 @@ div.select2-drop {
}
.actionPanel .myBlockContainer {
- margin:20px;
+ margin:19px;
padding: 20px;
width: 600px;
min-height: 200px;
http://git-wip-us.apache.org/repos/asf/isis/blob/13eb2002/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
index 1113641..a587f90 100644
--- a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
+++ b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
@@ -48,7 +48,6 @@ import org.apache.isis.applib.services.exceprecog.ExceptionRecognizerComposite;
import org.apache.isis.core.commons.authentication.AuthenticationSession;
import org.apache.isis.core.commons.authentication.MessageBroker;
import org.apache.isis.core.commons.config.IsisConfiguration;
-import org.apache.isis.core.commons.lang.StringExtensions;
import org.apache.isis.core.metamodel.services.ServicesInjectorSpi;
import org.apache.isis.core.metamodel.spec.SpecificationLoaderSpi;
import org.apache.isis.core.runtime.system.context.IsisContext;
@@ -203,10 +202,11 @@ public abstract class PageAbstract extends WebPage implements ActionPromptProvid
return pageClassRegistry.getPageClass(PageType.SIGN_IN);
}
- private static String asCssStyle(final String str) {
- return StringExtensions.asLowerDashed(str);
+ static String asCssStyle(final String str) {
+ return str.toLowerCase().replaceAll("[^A-Za-z0-9 ]", "").replaceAll("\\s+", "-");
}
+
protected ExceptionModel recognizeException(Exception ex) {
List<ExceptionRecognizer> exceptionRecognizers;
try {
http://git-wip-us.apache.org/repos/asf/isis/blob/13eb2002/component/viewer/wicket/ui/src/test/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstractTest.java
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/test/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstractTest.java b/component/viewer/wicket/ui/src/test/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstractTest.java
new file mode 100644
index 0000000..6080681
--- /dev/null
+++ b/component/viewer/wicket/ui/src/test/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstractTest.java
@@ -0,0 +1,23 @@
+package org.apache.isis.viewer.wicket.ui.pages;
+
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public abstract class PageAbstractTest {
+
+ public static class AsCssStyle extends PageAbstractTest {
+
+ @Test
+ public void withSpacesAndCapitals() throws Exception {
+ assertThat(PageAbstract.asCssStyle("Simple App"), is("simple-app"));
+ }
+
+ @Test
+ public void withOtherCharacters() throws Exception {
+ assertThat(PageAbstract.asCssStyle("Kitchen Sink (Demo) App"), is("kitchen-sink-demo-app"));
+ }
+
+ }
+}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/isis/blob/13eb2002/core/runtime/src/main/java/org/apache/isis/core/runtime/persistence/objectstore/transaction/PublishingServiceWithDefaultPayloadFactories.java
----------------------------------------------------------------------
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/persistence/objectstore/transaction/PublishingServiceWithDefaultPayloadFactories.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/persistence/objectstore/transaction/PublishingServiceWithDefaultPayloadFactories.java
index de3198e..f7c7466 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/persistence/objectstore/transaction/PublishingServiceWithDefaultPayloadFactories.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/persistence/objectstore/transaction/PublishingServiceWithDefaultPayloadFactories.java
@@ -49,6 +49,9 @@ public class PublishingServiceWithDefaultPayloadFactories {
private final static Function<ObjectAdapter, ObjectAdapter> NOT_DESTROYED_ELSE_EMPTY = new Function<ObjectAdapter, ObjectAdapter>() {
public ObjectAdapter apply(ObjectAdapter adapter) {
+ if(adapter == null) {
+ return null;
+ }
if (!adapter.isDestroyed()) {
return adapter;
}