[GitHub] [drill] cgivre commented on pull request #2133: DRILL-7834: Add Utility Functions for Compressed Files

[GitBox <gi...@apache.org>]

cgivre commented on pull request #2133:
URL: https://github.com/apache/drill/pull/2133#issuecomment-753733624


   > @cgivre The `To EVF` work needs these good ideas. Is it possible to add a comment for `openPossiblyCompressedStream()` function to describe the differences of them?
   
   @luocooong 
   Thanks for the review.   The `openPossiblyCompressedStream()` function opens an InputStream but if the file is compressed you can get a ZipCompressedStream or something like that.  In most cases, it won't matter, however, I found that in the case of a proprietary plugin that I was working on which read a byte array.  I'm not sure exactly why, but the Zip stream was breaking the reader.   The plugin in question also didn't work on S3 for the same reason.   
   
   I'm working on refactoring the LTSV plugin and was running into the same issue.   Hopefully this will make future development a little easier. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org