You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/25 00:35:13 UTC
[GitHub] [beam] robertwb commented on pull request #12881: [BEAM-7746] Get mypy passing on runners.worker
robertwb commented on pull request #12881:
URL: https://github.com/apache/beam/pull/12881#issuecomment-698656899
> 23:36:24 apache_beam/runners/worker/data_plane.py:714: error: Incompatible return value type (got "Optional[GrpcClientDataChannel]", expected "GrpcClientDataChannel") [return-value]
Sure this shouldn't return optional as well?
> 23:36:24 apache_beam/runners/worker/operations.py:722: error: Argument 1 to "append" of "list" has incompatible type "Tuple[DoOperation, Iterable[SplitResultResidual]]"; expected "Tuple[DoOperation, SplitResultResidual]" [arg-type]
self.dofn_runner.process does return an `Iterable[SplitResultResidual]`
> 23:36:24 apache_beam/runners/worker/bundle_processor.py:241: error: Signature of "try_split" incompatible with supertype "Operation" [override]
The supertype returns Optional[Any], which should be compatible with this.
> 23:36:24 apache_beam/runners/worker/bundle_processor.py:978: error: "Operation" has no attribute "add_timer_info" [attr-defined]
> 23:36:24 apache_beam/runners/worker/bundle_processor.py:990: error: "Operation" has no attribute "process_timer" [attr-defined]
These will always be DoOperations.
>23:36:24 apache_beam/runners/worker/bundle_processor.py:1568: error: Argument 5 to "StateBackedSideInputMap" has incompatible type "Coder"; expected "WindowedValueCoder" [arg-type]
I think this will always hold, we just don't know it due to having deserialized it with the generic mechanisms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org