You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/18 13:29:59 UTC
[GitHub] [nifi] markap14 commented on a change in pull request #5452: NIFI-9288: Updated data model to use for cnofig verification requests…
markap14 commented on a change in pull request #5452:
URL: https://github.com/apache/nifi/pull/5452#discussion_r730923155
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
##########
@@ -765,8 +772,54 @@ public ProcessorEntity updateProcessor(final Revision revision, final ProcessorD
}
@Override
- public List<ConfigVerificationResultDTO> verifyProcessorConfiguration(final String processorId, final ProcessorConfigDTO processorConfig, final Map<String, String> attributes) {
- return processorDAO.verifyProcessorConfiguration(processorId, processorConfig, attributes);
+ public List<ConfigVerificationResultDTO> verifyProcessorConfiguration(final String processorId, final Map<String, String> properties, final Map<String, String> attributes) {
+ return processorDAO.verifyProcessorConfiguration(processorId, properties, attributes);
+ }
+
+ @Override
+ public ConfigurationAnalysisEntity analyzeProcessorConfiguration(final String processorId, final Map<String, String> properties) {
+ final ProcessorNode processorNode = processorDAO.getProcessor(processorId);
+ final ProcessGroup processGroup = processorNode.getProcessGroup();
+ final ParameterContext parameterContext = processGroup.getParameterContext();
+
+ final Map<String, String> referencedAttributes = determineReferencedAttributes(properties, processorNode, parameterContext);
+
+ final ConfigurationAnalysisDTO dto = new ConfigurationAnalysisDTO();
+ dto.setComponentId(processorId);
+ dto.setProperties(properties);
+ dto.setReferencedAttributes(referencedAttributes);
+
+ final ConfigurationAnalysisEntity entity = new ConfigurationAnalysisEntity();
+ entity.setConfigurationAnalysis(dto);
+ return entity;
Review comment:
Yeah that's a good catch. Will do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org