You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2014/12/18 01:09:32 UTC
Review Request 29181: [WinGA] Add windows server assembly for AMS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs
-----
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8
ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae
ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
> On Dec. 18, 2014, 12:46 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, line 51
> > <https://reviews.apache.org/r/29181/diff/1/?file=795246#file795246line51>
> >
> > Emitter is a long running thread, which should continue to run even if there is an exception on sending metric data.
The signal we're waiting for is the process stop signal, which is normally not signaled, so, in 99.99% of the cases, that wait will behave exactly as a sleep. But, when the SIGTERM signal arrives, our internal process exit signal gets turned on and then the wait exits immediately.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65415
-----------------------------------------------------------
On Dec. 18, 2014, 12:09 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 12:09 a.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae
> ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65415
-----------------------------------------------------------
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
<https://reviews.apache.org/r/29181/#comment108526>
Emitter is a long running thread, which should continue to run even if there is an exception on sending metric data.
- Sid Wagle
On Dec. 18, 2014, 12:09 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 12:09 a.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae
> ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65442
-----------------------------------------------------------
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
<https://reviews.apache.org/r/29181/#comment108586>
The signal we're waiting for is the process stop signal, which is normally not signaled, so, in 99.99% of the cases, that wait will behave exactly as a sleep. But, when the SIGTERM signal arrives, our internal process exit signal gets turned on and then the wait exits immediately.
- Florian Barca
On Dec. 18, 2014, 12:09 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 12:09 a.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml 206f225268662a31802e9c88a48c98cb3ab963e8
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/amhm-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/assemblies/empty.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/amc.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 01f26fa905adfeebac0b625d3fca58e8399541ae
> ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/ats-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review65939
-----------------------------------------------------------
ambari-metrics/ambari-metrics-assembly/pom.xml
<https://reviews.apache.org/r/29181/#comment109211>
profile with id "windows" does not have closing tag
- Eugene Chekanskiy
On Dec. 19, 2014, 2:34 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 2:34 a.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
> ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
> ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
> ambari-metrics/ambari-metrics-assembly/pom.xml 0a0afbdd18532aad87eee6a67993e1a82f73dd98
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml 6080c8d16fecb0436ec539ed35527ff7a2d1ec87
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review66358
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On Dec. 30, 2014, 10:41 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 10:41 a.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
> ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
> ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
> ambari-common/src/main/python/ambari_commons/xml_utils.py PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/pom.xml 1e020cbf220ee614bd82e67a5b7538b277bdf806
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py 05362bfd55151ec0759b746924af3547c76bd703
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 196d7a12154f1903bd588c425eacf70c3525816d
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
> ambari-metrics/pom.xml da7fc14064889f09f102dcbcaabaca880ac4f8e7
> ambari-server/src/main/python/ambari-server-state/Entities.py 379c95f312ab7fac97e6f33b095b7a8883a94d94
> pom.xml af4fc01a078d202596ff42bc4659aadcc17663a3
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 10:41 a.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
Ignore previous diff - this is the correct continuation.
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
ambari-common/src/main/python/ambari_commons/xml_utils.py PRE-CREATION
ambari-metrics/ambari-metrics-assembly/pom.xml 1e020cbf220ee614bd82e67a5b7538b277bdf806
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py 05362bfd55151ec0759b746924af3547c76bd703
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 196d7a12154f1903bd588c425eacf70c3525816d
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
ambari-metrics/pom.xml da7fc14064889f09f102dcbcaabaca880ac4f8e7
ambari-server/src/main/python/ambari-server-state/Entities.py 379c95f312ab7fac97e6f33b095b7a8883a94d94
pom.xml af4fc01a078d202596ff42bc4659aadcc17663a3
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 10:35 a.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
+ Fixed unit tests
+ Added support for unit testing on MacOS and Windows
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-metrics/ambari-metrics-assembly/pom.xml 1e020cbf220ee614bd82e67a5b7538b277bdf806
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py 05362bfd55151ec0759b746924af3547c76bd703
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 196d7a12154f1903bd588c425eacf70c3525816d
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
ambari-metrics/pom.xml da7fc14064889f09f102dcbcaabaca880ac4f8e7
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review66294
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Dec. 26, 2014, 9:10 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 9:10 a.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
> ambari-common/src/main/python/ambari_commons/os_utils.py 6e2c1d2abee2c4d464dedb0344e3bf0ae08ea809
> ambari-common/src/main/python/ambari_commons/os_windows.py 0cc4ea232873a1130b8fd5a65deaa3324cd2efea
> ambari-common/src/main/python/ambari_commons/xml_utils.py PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/pom.xml 0a0afbdd18532aad87eee6a67993e1a82f73dd98
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
> ambari-metrics/pom.xml dde339a444276a1ce5fb9a4f5245e7f34394e990
> ambari-server/src/main/python/ambari-server-state/Entities.py 379c95f312ab7fac97e6f33b095b7a8883a94d94
> pom.xml 5d55074fa5c3a0745fb1a19a08893b3bba611993
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/#review66159
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On Dec. 26, 2014, 9:10 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29181/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 9:10 a.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-8770
> https://issues.apache.org/jira/browse/AMBARI-8770
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
>
> + Added Windows profiles to the Maven project files
> + Added the necessary Windows assemblies
> + Created Windows service skeletons
> + Host Monitoring: added OS-independent process termination handler
> + Collector: added debugging support for the Java process
>
>
> Diffs
> -----
>
> ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
> ambari-common/src/main/python/ambari_commons/os_utils.py 6e2c1d2abee2c4d464dedb0344e3bf0ae08ea809
> ambari-common/src/main/python/ambari_commons/os_windows.py 0cc4ea232873a1130b8fd5a65deaa3324cd2efea
> ambari-common/src/main/python/ambari_commons/xml_utils.py PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/pom.xml 0a0afbdd18532aad87eee6a67993e1a82f73dd98
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
> ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
> ambari-metrics/pom.xml dde339a444276a1ce5fb9a4f5245e7f34394e990
> ambari-server/src/main/python/ambari-server-state/Entities.py 379c95f312ab7fac97e6f33b095b7a8883a94d94
> pom.xml 5d55074fa5c3a0745fb1a19a08893b3bba611993
>
> Diff: https://reviews.apache.org/r/29181/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Smoke test on the local machine
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 26, 2014, 9:10 a.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
* Collector: added soft dependencies on the embedded HBase service
* Added support for the embedded HBase service setup
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
ambari-common/src/main/python/ambari_commons/os_utils.py 6e2c1d2abee2c4d464dedb0344e3bf0ae08ea809
ambari-common/src/main/python/ambari_commons/os_windows.py 0cc4ea232873a1130b8fd5a65deaa3324cd2efea
ambari-common/src/main/python/ambari_commons/xml_utils.py PRE-CREATION
ambari-metrics/ambari-metrics-assembly/pom.xml 0a0afbdd18532aad87eee6a67993e1a82f73dd98
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml c2130572a2ee32b8b35f7a89b8edd64f03aa22f4
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/embedded_hbase_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
ambari-metrics/pom.xml dde339a444276a1ce5fb9a4f5245e7f34394e990
ambari-server/src/main/python/ambari-server-state/Entities.py 379c95f312ab7fac97e6f33b095b7a8883a94d94
pom.xml 5d55074fa5c3a0745fb1a19a08893b3bba611993
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 2:34 a.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
Fixed faulty files in the previous patch.
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
ambari-metrics/ambari-metrics-assembly/pom.xml 0a0afbdd18532aad87eee6a67993e1a82f73dd98
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml 6080c8d16fecb0436ec539ed35527ff7a2d1ec87
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca
Re: Review Request 29181: [WinGA] Add windows server assembly for AMS
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29181/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 10:56 p.m.)
Review request for Ambari, Erik Bergenholtz, Eugene Chekanskiy, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
+ Fixed services shutdown, especially when joining spawned threads
Windows-specific:
+ Moved the assembly descriptors to ambari-metrics-assembly
+ Fixed comments in the configuration files
+ Added switch to skip checking embedded HBASE services for now. Will set them up in a follow-up checkin.
Bugs: AMBARI-8770
https://issues.apache.org/jira/browse/AMBARI-8770
Repository: ambari
Description
-------
Windows build for 2 Ambari Metrics service: Host Monitoring and Timeline Service (Collector).
+ Added Windows profiles to the Maven project files
+ Added the necessary Windows assemblies
+ Created Windows service skeletons
+ Host Monitoring: added OS-independent process termination handler
+ Collector: added debugging support for the Java process
Diffs (updated)
-----
ambari-agent/conf/windows/service_wrapper.py 40be1d0ef125ab299042ccfe71d313c420515624
ambari-common/src/main/python/ambari_commons/os_utils.py 3f4819d0b0306fd1bba09f0772c0a5cf458def60
ambari-common/src/main/python/ambari_commons/os_windows.py 2fb98e49478640ebfbabb820683c83331b7ed510
ambari-metrics/ambari-metrics-assembly/pom.xml 79d5ebab2f733437fdc59066877e854de9dd7f22
ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/assembly/monitor.xml 3513972d3b58f7e01016152f556c57b17fa18e6f
ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/ambari-metrics-monitor.cmd PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_groups.conf PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/conf/windows/metric_monitor.ini PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/pom.xml 6080c8d16fecb0436ec539ed35527ff7a2d1ec87
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/amhm_service.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/__init__.py 996120fd405bba2a43594343d618e23b3394d498
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py daabf37263fce558456cdc978822e41332478d91
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py 51f0980b82042b5c1b86781f37418457de0066c2
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py be83250b9a0113b0794a8874f37440c7d53065ec
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py PRE-CREATION
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py 09ae7e4750dc04266a5831626454077da3e71596
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ambari-metrics-collector.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-env.cmd PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/conf/windows/log4j.properties PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/pom.xml 5141359428c57291ee4e46a00b563f0c23d050a2
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/__init__.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/properties.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/ambari_metrics_collector/serviceConfiguration.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/amc_service.py PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/python/main.py PRE-CREATION
Diff: https://reviews.apache.org/r/29181/diff/
Testing
-------
mvn clean install
Smoke test on the local machine
Thanks,
Florian Barca