You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "joshgog (via GitHub)" <gi...@apache.org> on 2023/02/08 04:00:37 UTC
[GitHub] [solr] joshgog opened a new pull request, #1340: SOLR-16623:SolrClientTestRule for JettySolrRunner
joshgog opened a new pull request, #1340:
URL: https://github.com/apache/solr/pull/1340
https://issues.apache.org/jira/browse/SOLR-16623
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This PR introduces a SolrClientTestRule for JettySolrRunner
# Solution
Introduced SolrClientTestRule abstract class that extends JUnit's ExternalResource class, which is a TestRule that allows for specifying methods to be run before and after a test. SolrJettyTestRule is a concrete implementation of the abstract class and is declared as a ClassRule field in SolrJettyTestBase.
# Tests
The change is more of code refactoring. New tests are not required but the existing tests should pass
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joshgog closed pull request #1340: SOLR-16623:SolrClientTestRule for JettySolrRunner
Posted by "joshgog (via GitHub)" <gi...@apache.org>.
joshgog closed pull request #1340: SOLR-16623:SolrClientTestRule for JettySolrRunner
URL: https://github.com/apache/solr/pull/1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org