You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/08 05:45:18 UTC

[GitHub] [incubator-mxnet] luan1412167 commented on a change in pull request #13067: ONNX export: Scalar, Reshape - Set appropriate tensor type …

luan1412167 commented on a change in pull request #13067: ONNX export: Scalar, Reshape - Set appropriate tensor type  …
URL: https://github.com/apache/incubator-mxnet/pull/13067#discussion_r332343090
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -1840,7 +1840,7 @@ def convert_reshape(node, **kwargs):
     output_shape_list = convert_string_to_list(attrs["shape"])
 
     initializer = kwargs["initializer"]
-    output_shape_np = np.array(output_shape_list)
+    output_shape_np = np.array(output_shape_list, dtype='float32')
 
 Review comment:
   @zhreshold @vandanavk  output_shape_np = np.array(output_shape_list, dtype='float32'). Is int64 or float32 or float64 right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services