You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/12/24 06:44:56 UTC

[GitHub] [cordova-ios] dpogue opened a new pull request, #1276: Add support for Apple Cloud Distribution signing

dpogue opened a new pull request, #1276:
URL: https://github.com/apache/cordova-ios/pull/1276

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   This enables automatic provisioning with Apple Cloud Distribution certificates (which is really useful for cloud CI systems).
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This adds 3 new properties that can be specified on the command-line or via build.json, matching the 3 properties that need to be passed to xcodebuild to allow automatic cloud signing.
   
   I have some notes about how this works and how I set up automatic signing with GitHub Actions for a non-Cordova project here: https://gist.github.com/dpogue/d11df53cca6ba0e23d14d674ee5f9762
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Unit tests updated, still needs some further testing.
   
   Needs documentation updated.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] erisu merged pull request #1276: feat: Add support for Apple Cloud Distribution signing

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1276:
URL: https://github.com/apache/cordova-ios/pull/1276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-commenter commented on pull request #1276: Add support for Apple Cloud Distribution signing

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1276:
URL: https://github.com/apache/cordova-ios/pull/1276#issuecomment-1364564694

   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1276](https://codecov.io/gh/apache/cordova-ios/pull/1276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67fcc0d) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8ed0c08f05b946404083dec6a25040b03c7acb87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ed0c08) will **increase** coverage by `0.20%`.
   > The diff coverage is `87.50%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1276      +/-   ##
   ==========================================
   + Coverage   78.26%   78.47%   +0.20%     
   ==========================================
     Files          15       15              
     Lines        1767     1784      +17     
   ==========================================
   + Hits         1383     1400      +17     
     Misses        384      384              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `67.02% <87.50%> (+3.33%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org