[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4291: [INLONG-4232][Manager] Support collect data from a specified position for MySQL binlog

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4291:
URL: https://github.com/apache/incubator-inlong/pull/4291#discussion_r879964449


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/source/MySQLBinlogSource.java:
##########
@@ -100,4 +100,10 @@ public class MySQLBinlogSource extends StreamSource {
 
     @ApiModelProperty(value = "Primary key must be shared by all tables", required = false)
     private String primaryKey;
+
+    @ApiModelProperty("Directly read binlog from the specified offset filename")
+    public String specificOffsetFile;

Review Comment:
   Maybe change to the `offsetFile` and `offsetPosition` are more readable.



##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/CommandCreate.java:
##########
@@ -71,7 +71,7 @@ void run() {
                 }
             } catch (Exception e) {
                 System.out.println("Create group failed!");
-                System.out.println(e.getMessage());

Review Comment:
   Just printing the message of the exception is enough, thanks.



##########
inlong-manager/manager-client-tools/src/test/resources/create_group.json:
##########
@@ -0,0 +1,98 @@
+{
+  "groupInfo": {
+    "groupName": "test_group14",
+    "inlongGroupId": "b_test_group45",
+    "description": "",
+    "inCharges": "admin",
+    "proxyClusterId": "2",
+    "mqType": "PULSAR",
+    "mqBaseConf": {

Review Comment:
   That MQ config was changed, please change it with the latest branch, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org