[GitHub] [airflow] jedcunningham opened a new pull request #21308: Fix `oauth_whitelists` in BaseSecurityManager

[GitBox <gi...@apache.org>]

jedcunningham opened a new pull request #21308:
URL: https://github.com/apache/airflow/pull/21308


   Recent typing changes in `BaseSecurityManager` broke oauth integrations. This fixes it by initializing `oauth_whitelists` as an empty dict, like it is in FAB.
   
   Without a whitelist:
   ```
     File "/Users/jedc/Envs/af/lib/python3.7/site-packages/flask_appbuilder/security/views.py", line 674, in oauth_authorized
       if provider in self.appbuilder.sm.oauth_whitelists:
   AttributeError: 'AirflowSecurityManager' object has no attribute 'oauth_whitelists'
   ```
   
   With a whitelist:
   ```
     File "/Users/jedc/github/airflow/airflow/www/fab_security/manager.py", line 238, in __init__               
       self.oauth_whitelists[provider_name] = _provider["whitelist"]                              
   AttributeError: 'AirflowSecurityManager' object has no attribute 'oauth_whitelists'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21308: Fix `oauth_whitelists` in BaseSecurityManager

[GitBox <gi...@apache.org>]

potiuk merged pull request #21308:
URL: https://github.com/apache/airflow/pull/21308


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org