You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "cht42 (via GitHub)" <gi...@apache.org> on 2025/04/01 13:04:58 UTC
[PR] ArraySort: support structs [datafusion]
cht42 opened a new pull request, #15527:
URL: https://github.com/apache/datafusion/pull/15527
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #15526
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #15527:
URL: https://github.com/apache/datafusion/pull/15527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#issuecomment-2770318099
Close/reopen PR to retrigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#issuecomment-2773621630
Thanks again @cht42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023103674
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
valid.append_null();
} else {
let arr_ref = list_array.value(i);
- let arr_ref = arr_ref.as_ref();
- let sorted_array = compute::sort(arr_ref, sort_option)?;
+ let sorted_array = match arr_ref.data_type() {
+ DataType::Struct(_) => {
+ let sort_columns: Vec<SortColumn> = vec![SortColumn {
+ values: Arc::clone(&arr_ref),
+ options: sort_option,
+ }];
+ let indices = compute::lexsort_to_indices(&sort_columns, None)?;
+ compute::take(arr_ref.as_ref(), &indices, None)?
+ }
+ _ => {
+ let arr_ref = arr_ref.as_ref();
+ compute::sort(arr_ref, sort_option)?
Review Comment:
is the issue that arrow-rs 's sort kernel doesn't support sorting structures but `lexsort_to_indices` does?
Maybe we can offer some comments about why and possibly file an upstream ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "cht42 (via GitHub)" <gi...@apache.org>.
cht42 commented on code in PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023164133
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
valid.append_null();
} else {
let arr_ref = list_array.value(i);
- let arr_ref = arr_ref.as_ref();
- let sorted_array = compute::sort(arr_ref, sort_option)?;
+ let sorted_array = match arr_ref.data_type() {
+ DataType::Struct(_) => {
+ let sort_columns: Vec<SortColumn> = vec![SortColumn {
+ values: Arc::clone(&arr_ref),
+ options: sort_option,
+ }];
+ let indices = compute::lexsort_to_indices(&sort_columns, None)?;
+ compute::take(arr_ref.as_ref(), &indices, None)?
+ }
+ _ => {
+ let arr_ref = arr_ref.as_ref();
+ compute::sort(arr_ref, sort_option)?
Review Comment:
yes, `Struct` are not supported in `sort` https://github.com/apache/arrow-rs/blob/1b4acec18654c3aae7192100dbed1338cc863ea4/arrow-ord/src/sort.rs#L195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #15527: ArraySort: support structs
URL: https://github.com/apache/datafusion/pull/15527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "cht42 (via GitHub)" <gi...@apache.org>.
cht42 commented on code in PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023172721
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
valid.append_null();
} else {
let arr_ref = list_array.value(i);
- let arr_ref = arr_ref.as_ref();
- let sorted_array = compute::sort(arr_ref, sort_option)?;
+ let sorted_array = match arr_ref.data_type() {
+ DataType::Struct(_) => {
+ let sort_columns: Vec<SortColumn> = vec![SortColumn {
+ values: Arc::clone(&arr_ref),
+ options: sort_option,
+ }];
+ let indices = compute::lexsort_to_indices(&sort_columns, None)?;
+ compute::take(arr_ref.as_ref(), &indices, None)?
+ }
+ _ => {
+ let arr_ref = arr_ref.as_ref();
+ compute::sort(arr_ref, sort_option)?
Review Comment:
https://github.com/apache/arrow-rs/issues/6911#issuecomment-2562928843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023199085
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
valid.append_null();
} else {
let arr_ref = list_array.value(i);
- let arr_ref = arr_ref.as_ref();
- let sorted_array = compute::sort(arr_ref, sort_option)?;
+ let sorted_array = match arr_ref.data_type() {
Review Comment:
```suggestion
// arrow sort kernel does not support Structs, so use
// lexsort_to_indices instead:
// https://github.com/apache/arrow-rs/issues/6911#issuecomment-2562928843
let sorted_array = match arr_ref.data_type() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ArraySort: support structs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #15527:
URL: https://github.com/apache/datafusion/pull/15527#discussion_r2023199823
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -207,9 +208,21 @@ pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
valid.append_null();
} else {
let arr_ref = list_array.value(i);
- let arr_ref = arr_ref.as_ref();
- let sorted_array = compute::sort(arr_ref, sort_option)?;
+ let sorted_array = match arr_ref.data_type() {
+ DataType::Struct(_) => {
+ let sort_columns: Vec<SortColumn> = vec![SortColumn {
+ values: Arc::clone(&arr_ref),
+ options: sort_option,
+ }];
+ let indices = compute::lexsort_to_indices(&sort_columns, None)?;
+ compute::take(arr_ref.as_ref(), &indices, None)?
+ }
+ _ => {
+ let arr_ref = arr_ref.as_ref();
+ compute::sort(arr_ref, sort_option)?
Review Comment:
Thanks! I have added that context as a comment in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org