You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@uk.radan.com> on 2007/07/10 13:34:50 UTC
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Randy Kobes wrote:
> On Fri, 30 Mar 2007, Steve Hay wrote:
>> However, something else now seems to be amiss too because after
>> applying that patch and then building mod_perl-1.30 I find that "nmake
>> test" doesn't do anything: it spits out the following lines (only) and
>> then hangs until I Ctrl+C it:
>
> This seems to be a result from some white space added in
> the generated Makefile - does the attached patch work?
> Also, as I don't have Apache/1.3 on Unix, could someone
> try this out there to make sure it's OK? Thanks.
>
> =======================================================
> Index: Makefile.PL
> ===================================================================
> --- Makefile.PL (revision 524700)
> +++ Makefile.PL (working copy)
> @@ -178,7 +178,7 @@
> write_version_h("src/modules/perl");
>
> my(@test_pre_init) = qq(
> - test_pre_init:
> +test_pre_init:
> );
>
> # Automatic setup support
> @@ -1540,10 +1540,10 @@
>
> join '', @test_pre_init,
> qq(
> - MP_TEST_SCRIPT=$script
> +MP_TEST_SCRIPT=$script
> ),
> q(
> - TEST_VERBOSE=0
> +TEST_VERBOSE=0
>
> kill_httpd:
> kill `cat t/logs/httpd.pid`
>
> ====================================================
The above patch never got applied, so mod_perl-1.x still suffers that
Makefile breakage at the moment. Is there any reason that it wasn't applied?
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Randy Kobes wrote:
> On Tue, 10 Jul 2007, Geoffrey Young wrote:
>
>>> The above patch never got applied, so mod_perl-1.x still suffers that
>>> Makefile breakage at the moment. Is there any reason that it wasn't
>>> applied?
>> probably simply due to insufficient cross-platform review :)
>
> It worked for me on Win32, with nmake, but I didn't apply
> it because I wasn't sure if it would break Unix, and
> I don't have a mod_perl-1.x Unix environment to test it.
> If someone could verify that it's OK on Unix (probably
> any flavour would do, as it's a make() issue), I'll apply
> it.
Tested just fine on my Fedora box, so that's a +1 from me.
------------------------------------------------------------------------
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 10 Jul 2007, Geoffrey Young wrote:
>
>> The above patch never got applied, so mod_perl-1.x still suffers that
>> Makefile breakage at the moment. Is there any reason that it wasn't
>> applied?
>
> probably simply due to insufficient cross-platform review :)
It worked for me on Win32, with nmake, but I didn't apply
it because I wasn't sure if it would break Unix, and
I don't have a mod_perl-1.x Unix environment to test it.
If someone could verify that it's OK on Unix (probably
any flavour would do, as it's a make() issue), I'll apply
it.
--
best regards,
Randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> The above patch never got applied, so mod_perl-1.x still suffers that
> Makefile breakage at the moment. Is there any reason that it wasn't
> applied?
probably simply due to insufficient cross-platform review :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org