You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/12 23:38:35 UTC

[GitHub] [airflow] mik-laj commented on a diff in pull request #27638: Add Cloud Run Operator

mik-laj commented on code in PR #27638:
URL: https://github.com/apache/airflow/pull/27638#discussion_r1020818878


##########
airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -332,6 +356,16 @@ def get_credentials_and_project_id(*args, **kwargs) -> tuple[google.auth.credent
     return _CredentialProvider(*args, **kwargs).get_credentials_and_project()
 
 
+def get_id_token_credentials(*args, **kwargs) -> tuple[google.auth.credentials.Credentials]:

Review Comment:
   I wonder how much this code has to do with the this code:
   https://github.com/apache/airflow/blob/0fd129f33792a95b06c4f4ad1f7ee83dc2f5cef5/airflow/providers/google/common/utils/id_token_credentials.py



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org