You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/08 18:59:52 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #12593: KAFKA-14196: Prevent fetching during the rebalancing

hachikuji commented on code in PR #12593:
URL: https://github.com/apache/kafka/pull/12593#discussion_r966321913


##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1282,6 +1282,11 @@ private Fetch<K, V> pollForFetches(Timer timer) {
         long pollTimeout = coordinator == null ? timer.remainingMs() :
                 Math.min(coordinator.timeToNextPoll(timer.currentTimeMs()), timer.remainingMs());
 
+        if(coordinator.isCommittingOffsetAsync()) {

Review Comment:
   Hmm, do we want to do this in the general case? I think my expectation is that we would not continue fetching for partitions only when we have sent the offset commit and we are awaiting revocation as part of a rebalance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org