[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!

["HBase QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872986#comment-16872986 ] 

HBase QA commented on HBASE-22631:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red} HBASE-22631 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22631 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12972928/correct-assignprocedure-handlerFailureV1.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/578/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> assign failed may make gced parent region appear again !!!
> ----------------------------------------------------------
>
>                 Key: HBASE-22631
>                 URL: https://issues.apache.org/jira/browse/HBASE-22631
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.1.1
>            Reporter: yuhuiyang
>            Priority: Major
>         Attachments: correct-assignprocedure-handlerFailureV1.patch
>
>
> When i assign a region A the process is as follows：
> step1 : A is assigned to rs1 , and rs1 fails to open it .
> step2 : assignProcedure handleFailure .
> step3 : A is assign to rs2 and rs success to open it .
> Above is the normal flow . However when rs1 is restart after the reigon A was split and GCRegionProcedure was successed , the region A appare again !
> The region is that reigon A is not removed from the serverMap correctly when assignprocedure handleFailure . Because the code regionNode.offline() make the regionNode's regionLocation to be null and make regionNode's state to OFFLINE . So when the code env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So when the rs1 restart event triggers a serverCrashProcedure, it will get reigons from serverMap and it will get the region A then A will be assigned and hdfs dir will be created. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)