You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/06/28 22:14:08 UTC
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
geoff@apache.org wrote:
>Author: geoff
>Date: Tue Jun 28 12:27:07 2005
>New Revision: 202272
>
>URL: http://svn.apache.org/viewcvs?rev=202272&view=rev
>Log:
>skip on 2.1 until I have the time to figure out what changed
>
>Modified:
> perl/modperl/trunk/t/apache/content_length_header.t
>
>Modified: perl/modperl/trunk/t/apache/content_length_header.t
>URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/t/apache/content_length_header.t?rev=202272&r1=202271&r2=202272&view=diff
>==============================================================================
>--- perl/modperl/trunk/t/apache/content_length_header.t (original)
>+++ perl/modperl/trunk/t/apache/content_length_header.t Tue Jun 28 12:27:07 2005
>@@ -5,7 +5,10 @@
> use Apache::TestUtil;
> use Apache::TestRequest;
>
>-plan tests => 12 * 2 + 3;
>+my $skip = skip_reason('investigating 2.1 C-L behaviors')
>+ if have_min_apache_version(2.1);
>+
>+plan tests => 12 * 2 + 3, $skip;
>
> my $location = "/TestApache__content_length_header";
>
>
>
>
Isn't it an error to write an "if" on a "my" (variable declaration line)
like the above
$skip = have_min_apache_version(2.1) ? skip_reason('investigating 2.1
C-L behaviors') : '';
or the like ?
--
END
---------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> Geoffrey Young wrote:
>
>>>
>>>
>>>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>>
>>>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>>
>
> Ahh you just meant the ? returning the same thing in both cases.
> Should I commit after fixing that to be simpler ?
sure :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>>
>>
>>>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>
>>>>
>>>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>
>>>>
Ahh you just meant the ? returning the same thing in both cases.
Should I commit after fixing that to be simpler ?
--
END
---------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> Geoffrey Young wrote:
>
>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>
>>
>>
>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>
>>
>>
>> that looks awfully odd :)
>>
>> --Geoff
>
> I'll do some more digging during the week. :)
I hope you know it was just the syntax I was winking at :)
from your patch it looks like 2.1 behavior was "fixed" to match 2.0, which
is great. and if that's true we only need one definition I'd think, not ? :
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>
>
>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>
>
> that looks awfully odd :)
>
> --Geoff
I'll do some more digging during the week. :)
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
that looks awfully odd :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
>> URL: http://svn.apache.org/viewcvs?rev=202272&view=rev
>> Log:
>> skip on 2.1 until I have the time to figure out what changed
This patch fixes the content_length_header tests so we don't have to
skip them. (attached)
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Isn't it an error to write an "if" on a "my" (variable declaration line)
> like the above
the "error" you're talking about is the
my $x if 0;
ism that causes localization problems in some instances.
http://perl.com/pub/a/2000/05/p5pdigest/THISWEEK-20000521.html#my_x_if_0;_Trick
I doubt it would cause problems in this case since the variable in
question is examined only once - there are no future invocations where
it might collide.
but maybe it's bad form nonetheless. 'our' scope is probably sufficient
in addition to the fix you suggest, but only if it's really bugging you :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org