You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by do...@apache.org on 2024/02/20 20:35:50 UTC
(accumulo-access) branch replaceAuthorizer updated (e5c63a5 -> e16d3e1)
This is an automated email from the ASF dual-hosted git repository.
domgarguilo pushed a change to branch replaceAuthorizer
in repository https://gitbox.apache.org/repos/asf/accumulo-access.git
from e5c63a5 Replace Authorizer with Predicate<String>
add beea96b Change project version to 1.0.0-beta-SNAPSHOT (#49)
add 96896b2 Fix and simplify javadoc for AccessEvaluator (#52)
add e6e8e19 Move and simplify the AccessExample (#51)
add 846904f Fix markdown syntax
add 6451678 Update release candidate script
add 009246e Convert antlr4-example into an integration test (#53)
add d0b4423 moves thread local access outside of loop (#61)
add 202a51c Added post-vote-checklist issue templates (#44)
add 1c6051d [maven-release-plugin] prepare release rel/1.0.0-beta
add afe80dd [maven-release-plugin] prepare for next development iteration
add e0abc5d Merge branch '1.0.0-beta-rc4-next'
add 374a81e Update README to remove `contrib` project ref
add 2da31d3 Merge pull request #62 from ddanielr/Remove-contrib-ref
new 790c20e Merge remote-tracking branch 'upstream/main' into replaceAuthorizer
new e16d3e1 Fix javadoc wording
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/ISSUE_TEMPLATE/post_vote_checklist.md | 41 +++++++
.gitignore | 31 ++---
LICENSE | 9 ++
README.md | 40 ++++++-
SPECIFICATION.md | 2 +-
contrib/antlr4/README.md | 31 -----
contrib/getting-started/README.md | 98 ----------------
.../src/main/java/gse/AccessExample.java | 66 -----------
pom.xml | 123 +++++++++++++-------
src/build/create-release-candidate.sh | 18 +--
src/it/antlr4-example/README.md | 53 +++++++++
.../it/antlr4-example/invoker.properties | 6 +-
{contrib/antlr4 => src/it/antlr4-example}/pom.xml | 94 +++-------------
.../it/antlr4-example}/src/main/antlr4/Abnf.g4 | 125 ++++++++++-----------
.../src/main/antlr4/AccessExpression.g4 | 6 +-
.../accumulo/access/antlr/TestDataLoader.java | 6 +-
.../accumulo/access/grammar/SpecificationTest.java | 8 +-
.../antlr/AccessExpressionAntlrBenchmark.java | 0
.../antlr/AccessExpressionAntlrEvaluator.java | 0
.../grammar/antlr/AccessExpressionAntlrParser.java | 0
.../accumulo/access/grammar/antlr/Antlr4Tests.java | 0
.../getting-started/pom.xml => src/it/settings.xml | 59 +++++-----
.../apache/accumulo/access/AccessEvaluator.java | 28 +++--
.../accumulo/access/AccessEvaluatorImpl.java | 4 +-
.../access/specification/AccessExpression.abnf | 0
src/test/java/example/AccessExample.java | 86 ++++++++++++++
src/test/java/example/AccessExampleTest.java | 48 ++++++++
.../accumulo/access/AccessEvaluatorTest.java | 3 -
.../accumulo/access/AccessExpressionTest.java | 35 ++++++
29 files changed, 546 insertions(+), 474 deletions(-)
create mode 100644 .github/ISSUE_TEMPLATE/post_vote_checklist.md
delete mode 100644 contrib/antlr4/README.md
delete mode 100644 contrib/getting-started/README.md
delete mode 100644 contrib/getting-started/src/main/java/gse/AccessExample.java
create mode 100644 src/it/antlr4-example/README.md
rename contrib/getting-started/run.sh => src/it/antlr4-example/invoker.properties (84%)
mode change 100755 => 100644
rename {contrib/antlr4 => src/it/antlr4-example}/pom.xml (50%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/main/antlr4/Abnf.g4 (65%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/main/antlr4/AccessExpression.g4 (94%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/antlr/TestDataLoader.java (94%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/grammar/SpecificationTest.java (92%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/grammar/antlr/AccessExpressionAntlrBenchmark.java (100%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/grammar/antlr/AccessExpressionAntlrEvaluator.java (100%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/grammar/antlr/AccessExpressionAntlrParser.java (100%)
rename {contrib/antlr4 => src/it/antlr4-example}/src/test/java/org/apache/accumulo/access/grammar/antlr/Antlr4Tests.java (100%)
rename contrib/getting-started/pom.xml => src/it/settings.xml (50%)
rename contrib/antlr4/src/test/resources/specification.abnf => src/main/resources/org/apache/accumulo/access/specification/AccessExpression.abnf (100%)
create mode 100644 src/test/java/example/AccessExample.java
create mode 100644 src/test/java/example/AccessExampleTest.java
(accumulo-access) 02/02: Fix javadoc wording
Posted by do...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
domgarguilo pushed a commit to branch replaceAuthorizer
in repository https://gitbox.apache.org/repos/asf/accumulo-access.git
commit e16d3e172ed18d8f01795e524c90a82ee7ead65a
Author: Dom G <do...@apache.org>
AuthorDate: Tue Feb 20 15:35:38 2024 -0500
Fix javadoc wording
---
src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java b/src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java
index 74dcd86..5dec7ca 100644
--- a/src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java
+++ b/src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java
@@ -74,7 +74,7 @@ final class AccessEvaluatorImpl implements AccessEvaluator {
}
/**
- * Create an AccessEvaluatorImpl using an Predicate<String> object
+ * Create an AccessEvaluatorImpl using a Predicate<String>
*/
AccessEvaluatorImpl(Predicate<String> authorizationChecker) {
this.authorizedPredicates = List.of(auth -> authorizationChecker.test(unescape(auth)));
(accumulo-access) 01/02: Merge remote-tracking branch 'upstream/main' into replaceAuthorizer
Posted by do...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
domgarguilo pushed a commit to branch replaceAuthorizer
in repository https://gitbox.apache.org/repos/asf/accumulo-access.git
commit 790c20eaeead0393edcc6d04d3d1d5f137f98009
Merge: e5c63a5 2da31d3
Author: Dom G <do...@apache.org>
AuthorDate: Tue Feb 20 15:35:18 2024 -0500
Merge remote-tracking branch 'upstream/main' into replaceAuthorizer
# Conflicts:
# src/main/java/org/apache/accumulo/access/AccessEvaluator.java
.github/ISSUE_TEMPLATE/post_vote_checklist.md | 41 +++++++
.gitignore | 31 ++---
LICENSE | 9 ++
README.md | 40 ++++++-
SPECIFICATION.md | 2 +-
contrib/antlr4/README.md | 31 -----
contrib/getting-started/README.md | 98 ----------------
.../src/main/java/gse/AccessExample.java | 66 -----------
pom.xml | 123 +++++++++++++-------
src/build/create-release-candidate.sh | 18 +--
src/it/antlr4-example/README.md | 53 +++++++++
.../it/antlr4-example/invoker.properties | 6 +-
{contrib/antlr4 => src/it/antlr4-example}/pom.xml | 94 +++-------------
.../it/antlr4-example}/src/main/antlr4/Abnf.g4 | 125 ++++++++++-----------
.../src/main/antlr4/AccessExpression.g4 | 6 +-
.../accumulo/access/antlr/TestDataLoader.java | 6 +-
.../accumulo/access/grammar/SpecificationTest.java | 8 +-
.../antlr/AccessExpressionAntlrBenchmark.java | 0
.../antlr/AccessExpressionAntlrEvaluator.java | 0
.../grammar/antlr/AccessExpressionAntlrParser.java | 0
.../accumulo/access/grammar/antlr/Antlr4Tests.java | 0
.../getting-started/pom.xml => src/it/settings.xml | 59 +++++-----
.../apache/accumulo/access/AccessEvaluator.java | 28 +++--
.../accumulo/access/AccessEvaluatorImpl.java | 2 +-
.../access/specification/AccessExpression.abnf | 0
src/test/java/example/AccessExample.java | 86 ++++++++++++++
src/test/java/example/AccessExampleTest.java | 48 ++++++++
.../accumulo/access/AccessEvaluatorTest.java | 3 -
.../accumulo/access/AccessExpressionTest.java | 35 ++++++
29 files changed, 545 insertions(+), 473 deletions(-)
diff --cc src/main/java/org/apache/accumulo/access/AccessEvaluator.java
index bc6ef3d,1ea4d23..3caafe4
--- a/src/main/java/org/apache/accumulo/access/AccessEvaluator.java
+++ b/src/main/java/org/apache/accumulo/access/AccessEvaluator.java
@@@ -19,24 -19,13 +19,15 @@@
package org.apache.accumulo.access;
import java.util.Collection;
+import java.util.List;
+import java.util.function.Predicate;
/**
- * <p>
- * Used to decide if an entity with one more sets of authorizations can access zero or more access
- * expressions.
- * </p>
- * <p>
- * Note: For performance improvements, especially in cases where expressions are expected to repeat,
- * it's recommended to wrap this evaluator with an external caching mechanism, such as Guava's
- * cache, to leverage its extensive caching options. Caching is only safe under the assumption that
- * for an AccessEvaluator instance, evaluating the same expression multiple times will always yield
- * the same result. When considering caching, any environmental factors that might change this
- * assumption may need to be mitigated.
- * </p>
+ * This class is used to decide if an entity with a given set of authorizations can access
+ * subsequent access expressions.
*
- * Below is an example that should print false and then print true.
+ * <p>
+ * For example:
*
* <pre>
* {@code