[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2754: HDDS-5875. Do not cache tokens as part of Key Information.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2754:
URL: https://github.com/apache/ozone/pull/2754#discussion_r733902155



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -197,6 +197,14 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           new CacheKey<>(dbOpenKey),
           new CacheValue<>(Optional.absent(), trxnLogIndex));
 
+      // Strip out tokens before adding to cache.
+      // This way during listStatus token information does not pass on to
+      // client when returning from cache.
+      if (ozoneManager.isGrpcBlockTokenEnabled()) {
+        omKeyInfo.getLatestVersionLocations().getLocationList()
+            .forEach(keyInfo -> keyInfo.setToken(null));

Review comment:
       Thanks @adoroszlai for info. Nice catch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org