[GitHub] [activemq-artemis] clebertsuconic edited a comment on issue #2769: ARTEMIS-2414 Sync before closing file in case data loss

[GitBox <gi...@apache.org>]

clebertsuconic edited a comment on issue #2769: ARTEMIS-2414 Sync before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2769#issuecomment-516441207
 
 
   @wy96f I figured out: AIOSequentialFile::close(sync) was not closing the file if sync=false. I am fixing it. it's a previous issue that became unveiled when you changed the close.
   
   
   BTW: Did you see .sync actually taking time on a profiling?
   
   The information I had from a few kernel guys is that a sync call when there's no sync needed would be moot and not cause any issues. Although I can see some barrier between Java and Native layer here.
   
   is that what you saw? a barrier between native and Java, or an actual sync ocurring when nothing was needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services