You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/12/16 17:47:21 UTC

Re: git commit: TS-2335: add features for ts_lua


----- Original Message -----
> Updated Branches:
>   refs/heads/master 5b73f528d -> 7429793dc
> 
> 
> TS-2335: add features for ts_lua
> 
> 1) inject remap vars
> 2) free memory which is allocated by TSUrlStringGet
> 3) add ts.client_request.get_pristine_url()
> 
> Signed-off-by: Quehan <qu...@taobao.com>
> Signed-off-by: Yunkai Zhang <qi...@taobao.com>
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/7429793d
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/7429793d
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/7429793d
> 
> Branch: refs/heads/master
> Commit: 7429793dcc1e2715452723bd5d401cb6c114bec3
> Parents: 5b73f52
> Author: Quehan <qu...@taobao.com>
> Authored: Sun Dec 15 00:48:21 2013 +0800
> Committer: Yunkai Zhang <qi...@taobao.com>
> Committed: Mon Dec 16 15:10:01 2013 +0800
> 
> ----------------------------------------------------------------------
>  plugins/experimental/ts_lua/Makefile.am         |  2 +-
>  .../experimental/ts_lua/ts_lua_client_request.c | 45 ++++++++++++-
>  plugins/experimental/ts_lua/ts_lua_remap.c      | 67 ++++++++++++++++++++
>  plugins/experimental/ts_lua/ts_lua_remap.h      | 28 ++++++++
>  plugins/experimental/ts_lua/ts_lua_util.c       |  3 +
>  5 files changed, 142 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/7429793d/plugins/experimental/ts_lua/Makefile.am
> ----------------------------------------------------------------------
> diff --git a/plugins/experimental/ts_lua/Makefile.am
> b/plugins/experimental/ts_lua/Makefile.am
> index f1c1b27..a519578 100644
> --- a/plugins/experimental/ts_lua/Makefile.am
> +++ b/plugins/experimental/ts_lua/Makefile.am
> @@ -29,7 +29,7 @@ tslua_la_CPPFLAGS = \
>  pkglib_LTLIBRARIES = tslua.la
>  
>  tslua_la_LIBADD = $(LUA_LIBS)
> -tslua_la_SOURCES = ts_lua.c ts_lua_cached_response.c ts_lua_client_request.c
> ts_lua_client_response.c ts_lua_context.c ts_lua_hook.c ts_lua_http.c
> ts_lua_http_intercept.c ts_lua_log.c ts_lua_misc.c ts_lua_server_request.c
> ts_lua_server_response.c ts_lua_transform.c ts_lua_util.c
> +tslua_la_SOURCES = ts_lua.c ts_lua_cached_response.c ts_lua_client_request.c
> ts_lua_client_response.c ts_lua_context.c ts_lua_hook.c ts_lua_http.c
> ts_lua_http_intercept.c ts_lua_log.c ts_lua_misc.c ts_lua_server_request.c
> ts_lua_server_response.c ts_lua_transform.c ts_lua_util.c ts_lua_remap.c
>  tslua_la_LDFLAGS = $(TS_PLUGIN_LDFLAGS)
>  

For readability reasons we should break this down to one file per line, sorted alphabetically.


-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641


Re: git commit: TS-2335: add features for ts_lua

Posted by Yunkai Zhang <yu...@gmail.com>.
On Tue, Dec 17, 2013 at 12:47 AM, Igor Galić <i....@brainsware.org> wrote:

>
>
> ----- Original Message -----
> > Updated Branches:
> >   refs/heads/master 5b73f528d -> 7429793dc
> >
> >
> > TS-2335: add features for ts_lua
> >
> > 1) inject remap vars
> > 2) free memory which is allocated by TSUrlStringGet
> > 3) add ts.client_request.get_pristine_url()
> >
> > Signed-off-by: Quehan <qu...@taobao.com>
> > Signed-off-by: Yunkai Zhang <qi...@taobao.com>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/7429793d
> > Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/7429793d
> > Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/7429793d
> >
> > Branch: refs/heads/master
> > Commit: 7429793dcc1e2715452723bd5d401cb6c114bec3
> > Parents: 5b73f52
> > Author: Quehan <qu...@taobao.com>
> > Authored: Sun Dec 15 00:48:21 2013 +0800
> > Committer: Yunkai Zhang <qi...@taobao.com>
> > Committed: Mon Dec 16 15:10:01 2013 +0800
> >
> > ----------------------------------------------------------------------
> >  plugins/experimental/ts_lua/Makefile.am         |  2 +-
> >  .../experimental/ts_lua/ts_lua_client_request.c | 45 ++++++++++++-
> >  plugins/experimental/ts_lua/ts_lua_remap.c      | 67
> ++++++++++++++++++++
> >  plugins/experimental/ts_lua/ts_lua_remap.h      | 28 ++++++++
> >  plugins/experimental/ts_lua/ts_lua_util.c       |  3 +
> >  5 files changed, 142 insertions(+), 3 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/7429793d/plugins/experimental/ts_lua/Makefile.am
> > ----------------------------------------------------------------------
> > diff --git a/plugins/experimental/ts_lua/Makefile.am
> > b/plugins/experimental/ts_lua/Makefile.am
> > index f1c1b27..a519578 100644
> > --- a/plugins/experimental/ts_lua/Makefile.am
> > +++ b/plugins/experimental/ts_lua/Makefile.am
> > @@ -29,7 +29,7 @@ tslua_la_CPPFLAGS = \
> >  pkglib_LTLIBRARIES = tslua.la
> >
> >  tslua_la_LIBADD = $(LUA_LIBS)
> > -tslua_la_SOURCES = ts_lua.c ts_lua_cached_response.c
> ts_lua_client_request.c
> > ts_lua_client_response.c ts_lua_context.c ts_lua_hook.c ts_lua_http.c
> > ts_lua_http_intercept.c ts_lua_log.c ts_lua_misc.c
> ts_lua_server_request.c
> > ts_lua_server_response.c ts_lua_transform.c ts_lua_util.c
> > +tslua_la_SOURCES = ts_lua.c ts_lua_cached_response.c
> ts_lua_client_request.c
> > ts_lua_client_response.c ts_lua_context.c ts_lua_hook.c ts_lua_http.c
> > ts_lua_http_intercept.c ts_lua_log.c ts_lua_misc.c
> ts_lua_server_request.c
> > ts_lua_server_response.c ts_lua_transform.c ts_lua_util.c ts_lua_remap.c
> >  tslua_la_LDFLAGS = $(TS_PLUGIN_LDFLAGS)
> >
>
> For readability reasons we should break this down to one file per line,
> sorted alphabetically.
>


Agree, I'll ask @Quehan to refine it.

Thanks.


>
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641
>
>


-- 
Yunkai Zhang
Work at Taobao