Re: Review Request 60486: GEODE-3105: Adding handler for GetRegions

[Brian Rowe <br...@pivotal.io>]

> On June 28, 2017, 3:53 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
> > Line 50 (original), 50 (patched)
> > <https://reviews.apache.org/r/60486/diff/1/?file=1764594#file1764594line50>
> >
> >     Feels like this is going to end up being a TranslationUtilService. Can you discusss internally... `wrapResponseForOperationTypeID` is a candidate for movement as well...

These functions are no longer necessary and have been removed in the GEODE-3129 change.


> On June 28, 2017, 3:53 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/proto/region_API.proto
> > Line 107 (original), 107 (patched)
> > <https://reviews.apache.org/r/60486/diff/1/?file=1764597#file1764597line107>
> >
> >     What does this represent? `Failure` should be defined in the  `Success` can be defined as either an empty or populated regions list.
> >     
> >     In the `ResponseHeader` does contain an `errorCode`. What we seem to be missing is a real `ErrorMessage`, that would contain the `exceptionCode` and `errorMessage`.

This has been removed.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60486/#review179070
-----------------------------------------------------------


On June 27, 2017, 11:31 p.m., Brian Rowe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60486/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 11:31 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3105
>     https://issues.apache.org/jira/browse/GEODE-3105
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added a handler which will catch incoming getRegion requests and will call into the cache's rootRegion and return the names of the regions it finds.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java 8edd83c0f 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java 29d33170c 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java 21dbef5bc 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandler.java PRE-CREATION 
>   geode-protobuf/src/main/proto/region_API.proto adeb011c6 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 73d0803b6 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java 1fbe82159 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60486/diff/1/
> 
> 
> Testing
> -------
> 
> Added unit test verifying hanlder behavior.
> Added integration test verifying module correctness for getRegion.
> Running precheckin.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>