You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "ilgrosso (via GitHub)" <gi...@apache.org> on 2026/05/06 12:38:06 UTC
[PR] [SYNCOPE-1967] Support for CAS Attribute Release Consent [syncope]
ilgrosso opened a new pull request, #1378:
URL: https://github.com/apache/syncope/pull/1378
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1967] Support for CAS Attribute Release Consent [syncope]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #1378:
URL: https://github.com/apache/syncope/pull/1378#discussion_r3195537331
##########
client/am/console/src/main/java/org/apache/syncope/client/console/authprofiles/AuthProfileWizardBuilder.java:
##########
@@ -66,7 +91,32 @@
Step(final T modelObject) {
model.setObject(modelObject);
model.setInitialModelObject(modelObject);
- add(new BeanPanel<>("bean", model, pageRef).setRenderBodyOnly(true));
+ add(new BeanPanel<>("bean", model, pageRef, excluded == null ? null : excluded.toArray(String[]::new)).
+ setRenderBodyOnly(true));
+ }
+ }
+
+ protected class ConsentAttributes extends WizardStep {
Review Comment:
## CodeQL / Inner class could be static
ConsentAttributes could be made static, since the enclosing instance is used only in its constructor.
[Show more details](https://github.com/apache/syncope/security/code-scanning/2615)
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/to/AuthProfileTO.java:
##########
@@ -166,6 +214,10 @@
return webAuthnDeviceCredentials;
}
+ public List<WAConsentDecision> getConsentDecisions() {
Review Comment:
## CodeQL / Exposing internal representation
getConsentDecisions exposes the internal representation stored in field consentDecisions. The value may be modified [after this call to getConsentDecisions](1).
[Show more details](https://github.com/apache/syncope/security/code-scanning/2614)
##########
common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/ConsentDecisionService.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.common.rest.api.service.wa;
+
+import io.swagger.v3.oas.annotations.security.SecurityRequirement;
+import io.swagger.v3.oas.annotations.security.SecurityRequirements;
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.DELETE;
+import jakarta.ws.rs.GET;
+import jakarta.ws.rs.PUT;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.QueryParam;
+import jakarta.ws.rs.core.MediaType;
+import org.apache.syncope.common.lib.to.PagedResult;
+import org.apache.syncope.common.lib.wa.WAConsentDecision;
+import org.apache.syncope.common.rest.api.service.JAXRSService;
+
+@Tag(name = "WA")
+@SecurityRequirements({
+ @SecurityRequirement(name = "BasicAuthentication"),
+ @SecurityRequirement(name = "Bearer") })
+@Path("wa/consentDecision")
+public interface ConsentDecisionService extends JAXRSService {
Review Comment:
## CodeQL / Constant interface anti-pattern
Type ConsentDecisionService implements constant interface [JAXRSService](1).
[Show more details](https://github.com/apache/syncope/security/code-scanning/2613)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYNCOPE-1967] Support for CAS Attribute Release Consent [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #1378:
URL: https://github.com/apache/syncope/pull/1378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org